Bug 23062 - [jsfunfuzz] Computed exception offset wrong when first instruction is attempt to resolve deleted eval
Summary: [jsfunfuzz] Computed exception offset wrong when first instruction is attempt...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Oliver Hunt
URL:
Keywords:
Depends on:
Blocks: 13638
  Show dependency treegraph
 
Reported: 2008-12-31 17:44 PST by Oliver Hunt
Modified: 2008-12-31 18:34 PST (History)
0 users

See Also:


Attachments
Emit expression info for the eval resolve (3.57 KB, patch)
2008-12-31 18:24 PST, Oliver Hunt
barraclough: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2008-12-31 17:44:25 PST
delete eval;
(function(){ try { eval("") } catch(e) { print("ARGHH!!!") } })()

Results in an assertion failure as it fails to find the correct handler offset when resolving eval fails.
Comment 1 Oliver Hunt 2008-12-31 18:07:48 PST
Have fix, we weren't correctly emitting position information for the resolve of "eval" in the eval call node.  Just making tests.
Comment 2 Oliver Hunt 2008-12-31 18:24:21 PST
Created attachment 26342 [details]
Emit expression info for the eval resolve

Nice and easy fix
Comment 3 Oliver Hunt 2008-12-31 18:34:14 PST
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	JavaScriptCore/ChangeLog
	M	JavaScriptCore/parser/Nodes.cpp
	M	LayoutTests/ChangeLog
	M	LayoutTests/fast/js/exception-linenums-expected.txt
	M	LayoutTests/fast/js/resources/exception-linenums.js
Committed r39533