Bug 230609 - AX: aria-expanded is no longer supported on quite a few roles in ARIA 1.2
Summary: AX: aria-expanded is no longer supported on quite a few roles in ARIA 1.2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joanmarie Diggs
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-09-22 04:11 PDT by Joanmarie Diggs
Modified: 2021-09-25 01:07 PDT (History)
9 users (show)

See Also:


Attachments
Patch (14.93 KB, patch)
2021-09-23 10:54 PDT, Joanmarie Diggs
no flags Details | Formatted Diff | Diff
Patch (15.86 KB, patch)
2021-09-24 01:32 PDT, Joanmarie Diggs
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (16.90 KB, patch)
2021-09-24 07:10 PDT, Joanmarie Diggs
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joanmarie Diggs 2021-09-22 04:11:14 PDT
Steps to reproduce:
1. View data:text/html,<div role="dialog" aria-expanded="true"></div>
2. Examine the dialog using XCode's Accessibility Inspector

Expected results: AXExpanded would not be true

Actual results: AXExpanded is true

A change was made in ARIA 1.2 removing aria-expanded as a supported property from a whole bunch of roles. See https://www.w3.org/TR/wai-aria-1.2/#aria-expanded. Dialog is just an example.

Under https://www.w3.org/TR/wai-aria-1.2/#state_property_processing, it says:

    User agents MUST ignore non-global states and properties used on an element without a role supporting the state or property;
Comment 1 Radar WebKit Bug Importer 2021-09-22 04:11:29 PDT
<rdar://problem/83392274>
Comment 2 Joanmarie Diggs 2021-09-23 07:20:08 PDT
Taking this one.
Comment 3 Joanmarie Diggs 2021-09-23 10:54:23 PDT
Created attachment 439065 [details]
Patch
Comment 4 Joanmarie Diggs 2021-09-24 01:32:11 PDT
Created attachment 439136 [details]
Patch
Comment 5 Joanmarie Diggs 2021-09-24 07:10:48 PDT
Created attachment 439143 [details]
Patch
Comment 6 Joanmarie Diggs 2021-09-24 23:10:16 PDT
Chris: Could you please re-review when you get a chance? I made a couple of small changes since the initial patch you r+ed. Thanks in advance!
Comment 7 chris fleizach 2021-09-25 00:28:23 PDT
(In reply to Joanmarie Diggs from comment #6)
> Chris: Could you please re-review when you get a chance? I made a couple of
> small changes since the initial patch you r+ed. Thanks in advance!

Looks ok

Thanks
Comment 8 EWS 2021-09-25 01:07:28 PDT
Committed r283078 (242136@main): <https://commits.webkit.org/242136@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 439143 [details].