Bug 230582 - [JSC] CompareStrictEq is omitting String check incorrectly
Summary: [JSC] CompareStrictEq is omitting String check incorrectly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-09-21 16:11 PDT by Yusuke Suzuki
Modified: 2021-09-21 18:14 PDT (History)
7 users (show)

See Also:


Attachments
Patch (12.83 KB, patch)
2021-09-21 16:14 PDT, Yusuke Suzuki
mark.lam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2021-09-21 16:11:01 PDT
[JSC] CompareStrictEq is omitting String check incorrectly
Comment 1 Yusuke Suzuki 2021-09-21 16:14:04 PDT
Created attachment 438879 [details]
Patch
Comment 2 Yusuke Suzuki 2021-09-21 16:14:07 PDT
<rdar://problem/83237121>
Comment 3 Mark Lam 2021-09-21 17:25:11 PDT
Comment on attachment 438879 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438879&action=review

r=me

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp:383
>      JITCompiler::JumpList trueCase;

Not due to your patch, but the comment above is incorrect: `if (left == true) {` ==> `if (left == right) {`
Comment 4 Yusuke Suzuki 2021-09-21 18:13:03 PDT
Comment on attachment 438879 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438879&action=review

>> Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp:383
>>      JITCompiler::JumpList trueCase;
> 
> Not due to your patch, but the comment above is incorrect: `if (left == true) {` ==> `if (left == right) {`

Thanks, fixed.
Comment 5 Yusuke Suzuki 2021-09-21 18:14:14 PDT
Committed r282857 (241988@main): <https://commits.webkit.org/241988@main>