Bug 230560 - [run-api-tests] Use temporary symlink when listing tests
Summary: [run-api-tests] Use temporary symlink when listing tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-09-21 09:37 PDT by Jonathan Bedard
Modified: 2021-10-20 13:23 PDT (History)
8 users (show)

See Also:


Attachments
Patch (1.95 KB, patch)
2021-09-22 09:02 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff
Patch (3.51 KB, patch)
2021-09-23 08:50 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff
Patch (3.77 KB, patch)
2021-09-23 08:54 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2021-09-21 09:37:12 PDT
To make debugging easier, we should use a symlink to list API tests instead of the actual binary.
Comment 1 Jonathan Bedard 2021-09-22 09:02:11 PDT
Created attachment 438954 [details]
Patch
Comment 2 Jonathan Bedard 2021-09-23 08:50:52 PDT
Created attachment 439047 [details]
Patch
Comment 3 Jonathan Bedard 2021-09-23 08:54:09 PDT
Created attachment 439048 [details]
Patch
Comment 4 Radar WebKit Bug Importer 2021-09-28 09:38:15 PDT
<rdar://problem/83626540>
Comment 5 dewei_zhu 2021-10-18 13:10:32 PDT
Comment on attachment 439048 [details]
Patch

r=me
Comment 6 EWS 2021-10-18 13:51:29 PDT
Committed r284398 (243174@main): <https://commits.webkit.org/243174@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 439048 [details].
Comment 7 Fujii Hironori 2021-10-20 13:23:26 PDT
WinCairo is failing after this change.
Filed: Bug 232037 – [Win Python] REGRESSION(r284398): run-api-tests: FileNotFoundError raised: [WinError 2] The system cannot find the file specified