Bug 230540 - [webkitcorepy] Not possible to autoinstall a package with micro version 0
Summary: [webkitcorepy] Not possible to autoinstall a package with micro version 0
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-09-21 02:14 PDT by Carlos Garcia Campos
Modified: 2021-10-08 16:26 PDT (History)
6 users (show)

See Also:

Attachments
Patch (5.40 KB, patch)
2021-10-08 09:57 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch for landing (6.73 KB, patch)
2021-10-08 11:14 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2021-09-21 02:14:06 PDT 
This happens if there are more versions of the package. For example try to install pytest 6.2.0, even when using Version (6, 2, 0), the installed version is 6.2.5. I think we should differentiate between Version(6, 2) and Version(6, 2, 0), probably initializing implicit arguments to None instead of 0 and handling None everywhere in version.py.
Comment 1 Jonathan Bedard 2021-09-21 07:31:12 PDT 
If we do end up doing this, it probably needs to be the special case, not the default one. I seem to recall this is the behavior we want when dealing with iOS/MacOS versions, although been a bit since I was dealing with this code
Comment 2 Radar WebKit Bug Importer 2021-09-28 02:15:16 PDT 
<rdar://problem/83613371>
Comment 3 Jonathan Bedard 2021-10-08 09:57:16 PDT 
Created attachment 440633 [details]
Patch
Comment 4 Jonathan Bedard 2021-10-08 11:14:05 PDT 
Created attachment 440647 [details]
Patch for landing
Comment 5 EWS 2021-10-08 12:19:24 PDT 
Committed r283824 (242711@main): <https://commits.webkit.org/242711@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 440647 [details].