REOPENED 230540
[webkitcorepy] Not possible to autoinstall a package with micro version 0 
https://bugs.webkit.org/show_bug.cgi?id=230540
Summary [webkitcorepy] Not possible to autoinstall a package with micro version 0
Carlos Garcia Campos
Reported 2021-09-21 02:14:06 PDT
This happens if there are more versions of the package. For example try to install pytest 6.2.0, even when using Version (6, 2, 0), the installed version is 6.2.5. I think we should differentiate between Version(6, 2) and Version(6, 2, 0), probably initializing implicit arguments to None instead of 0 and handling None everywhere in version.py.
Attachments
Patch (5.40 KB, patch)
2021-10-08 09:57 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch for landing (6.73 KB, patch)
2021-10-08 11:14 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2021-09-21 07:31:12 PDT
If we do end up doing this, it probably needs to be the special case, not the default one. I seem to recall this is the behavior we want when dealing with iOS/MacOS versions, although been a bit since I was dealing with this code
Radar WebKit Bug Importer
Comment 2 2021-09-28 02:15:16 PDT
<rdar://problem/83613371>
Jonathan Bedard
Comment 3 2021-10-08 09:57:16 PDT
Created attachment 440633 [details] Patch
Jonathan Bedard
Comment 4 2021-10-08 11:14:05 PDT
Created attachment 440647 [details] Patch for landing
EWS
Comment 5 2021-10-08 12:19:24 PDT
Committed r283824 (242711@main): <https://commits.webkit.org/242711@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 440647 [details].
Sam Sneddon [:gsnedders]
Comment 7 2024-11-06 15:40:19 PST
(In reply to Truitt Savell from comment #6) > Reverted https://trac.webkit.org/changeset/283824/webkit in: > https://trac.webkit.org/changeset/283850/webkit Per that commit message, "Reverting r283824 becasue it broke baseline search paths". We don't seem to have ever re-landed this.
Note You need to log in before you can comment on or make changes to this bug.