Bug 23054 - Caching of global lookups occurs even when the global object has become a dictionary
Summary: Caching of global lookups occurs even when the global object has become a dic...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Cameron Zwarich (cpst)
URL:
Keywords: InRadar
Depends on:
Blocks: 13638
  Show dependency treegraph
 
Reported: 2008-12-31 01:44 PST by Cameron Zwarich (cpst)
Modified: 2008-12-31 02:17 PST (History)
0 users

See Also:


Attachments
Proposed patch (4.53 KB, patch)
2008-12-31 02:14 PST, Cameron Zwarich (cpst)
oliver: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron Zwarich (cpst) 2008-12-31 01:44:36 PST
Both Interpreter::resolveGlobal() and Interpreter::cti_op_resolve_global() will cache even when the global object has transitioned to being a dictionary. This is incorrect.
Comment 1 Cameron Zwarich (cpst) 2008-12-31 01:45:30 PST
<rdar://problem/6469905>
Comment 2 Cameron Zwarich (cpst) 2008-12-31 02:14:25 PST
Created attachment 26333 [details]
Proposed patch

There is no change on SunSpider.
Comment 3 Cameron Zwarich (cpst) 2008-12-31 02:17:26 PST
Landed in r39525.