Bug 230521 - Remove unused enums.
Summary: Remove unused enums.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Megan Gardner
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-09-20 16:25 PDT by Megan Gardner
Modified: 2021-09-22 08:39 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.27 KB, patch)
2021-09-20 16:26 PDT, Megan Gardner
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (2.04 KB, patch)
2021-09-20 16:28 PDT, Megan Gardner
no flags Details | Formatted Diff | Diff
Patch (5.64 KB, patch)
2021-09-21 14:32 PDT, Megan Gardner
no flags Details | Formatted Diff | Diff
Patch (5.74 KB, patch)
2021-09-21 15:09 PDT, Megan Gardner
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Megan Gardner 2021-09-20 16:25:40 PDT
Test Patch for Bots.
Comment 1 Megan Gardner 2021-09-20 16:26:31 PDT
Created attachment 438749 [details]
Patch
Comment 2 Megan Gardner 2021-09-20 16:28:57 PDT
Created attachment 438751 [details]
Patch
Comment 3 Megan Gardner 2021-09-21 14:32:11 PDT
Created attachment 438859 [details]
Patch
Comment 4 Megan Gardner 2021-09-21 15:09:45 PDT
Created attachment 438864 [details]
Patch
Comment 5 Alex Christensen 2021-09-21 19:34:06 PDT
Comment on attachment 438864 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438864&action=review

> Source/WebKit/Shared/ios/GestureTypes.h:37
>      OneFingerDoubleTap,

This makes it so that GestureType::OneFingerDoubleTap is no longer equal to UIWKGestureOneFingerDoubleTap.  Similar looking changes have caused problems in the past.  This looks good, but please double check that the values from GestureType are not exposed in the API.
Comment 6 Wenson Hsieh 2021-09-22 07:58:13 PDT
Comment on attachment 438864 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438864&action=review

>> Source/WebKit/Shared/ios/GestureTypes.h:37
>>      OneFingerDoubleTap,
> 
> This makes it so that GestureType::OneFingerDoubleTap is no longer equal to UIWKGestureOneFingerDoubleTap.  Similar looking changes have caused problems in the past.  This looks good, but please double check that the values from GestureType are not exposed in the API.

These enum values are definitely all internal to WebKit (and not exposed in any clients, indirectly or directly).
Comment 7 EWS 2021-09-22 08:38:05 PDT
Committed r282877 (242006@main): <https://commits.webkit.org/242006@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 438864 [details].
Comment 8 Radar WebKit Bug Importer 2021-09-22 08:39:27 PDT
<rdar://problem/83401829>