Use typed identifier for WebSocketChannel identifiers
Created attachment 438692 [details] Patch
Comment on attachment 438692 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=438692&action=review > Source/WebCore/Modules/websockets/ThreadableWebSocketChannel.h:87 > + virtual WebSocketChannelIdentifier progressIdentifier() const = 0; Can we rename progressIdentifier as well to just identifier? > Source/WebCore/Modules/websockets/WebSocketChannelInspector.cpp:37 > + : m_progressIdentifier(WebSocketChannelIdentifier::generateThreadSafe()) { } I would have thought only WebSocketChannel would generate WebSocketChannelIdentifier, it is a bit odd but is a preexisting issue.
It can also never be zero now, so I'll remove the if (m_progressIdentifier) checks.
ThreadableWebSocketChannel already has identifier() which returns a WebSocketIdentifier
Committed r282818 (241949@main): <https://commits.webkit.org/241949@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 438692 [details].
<rdar://problem/83352793>