Bug 230482 - Refactor some code that controls Live Text selection behavior
Summary: Refactor some code that controls Live Text selection behavior
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-09-20 07:54 PDT by Wenson Hsieh
Modified: 2021-09-20 12:32 PDT (History)
10 users (show)

See Also:

Attachments
WIP (6.82 KB, patch)
2021-09-20 08:39 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Patch (7.56 KB, patch)
2021-09-20 09:37 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2021-09-20 07:54:34 PDT 
rdar://83173597
Comment 1 Wenson Hsieh 2021-09-20 08:39:52 PDT Comment hidden (obsolete)
Comment 2 Wenson Hsieh 2021-09-20 09:37:38 PDT 
Created attachment 438687 [details]
Patch
Comment 3 Megan Gardner 2021-09-20 10:09:56 PDT 
Comment on attachment 438687 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438687&action=review

> Source/WebCore/page/EventHandler.cpp:2529
> +    if (!candidateElement)

Why did you expand this?
Comment 4 Wenson Hsieh 2021-09-20 11:08:57 PDT 
Comment on attachment 438687 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438687&action=review

Thanks for the review!

>> Source/WebCore/page/EventHandler.cpp:2529
>> +    if (!candidateElement)
> 
> Why did you expand this?

Ah, good question. So I had actually inadvertently shrank this in https://trac.webkit.org/r282740, due to a mistake when breaking out my changes into these smaller patches :P

(It was originally intended to be just one larger refactoring, but I split it into smaller pieces to make it easier to review).
Comment 5 EWS 2021-09-20 12:32:41 PDT 
Committed r282769 (241904@main): <https://commits.webkit.org/241904@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 438687 [details].