RESOLVED FIXED230459
[lFC][Integration] Enable some text painting features 
https://bugs.webkit.org/show_bug.cgi?id=230459
Summary [lFC][Integration] Enable some text painting features
Antti Koivisto
Reported 2021-09-19 06:59:03 PDT
some more coverage
Attachments
Patch (5.38 KB, patch)
2021-09-19 07:35 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2021-09-19 07:35:14 PDT
Created attachment 438594 [details] Patch
Sam Weinig
Comment 2 2021-09-19 09:44:33 PDT
Comment on attachment 438594 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=438594&action=review > Source/WebCore/layout/integration/LayoutIntegrationCoverage.h:63 > + // Unused = 1LLU << 23, Are you doing this so you don't have to change all the numbers after this one? Or do these need to stay consistent across builds for serialization reasons? (either is ok, just curious)
alan
Comment 3 2021-09-19 09:46:35 PDT
(In reply to Sam Weinig from comment #2) > Comment on attachment 438594 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=438594&action=review > > > Source/WebCore/layout/integration/LayoutIntegrationCoverage.h:63 > > + // Unused = 1LLU << 23, > > Are you doing this so you don't have to change all the numbers after this > one? Or do these need to stay consistent across builds for serialization > reasons? (either is ok, just curious) The former. I tend to collapse it from time to time though.
EWS
Comment 4 2021-09-19 10:04:44 PDT
Committed r282737 (241874@main): <https://commits.webkit.org/241874@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 438594 [details].
Radar WebKit Bug Importer
Comment 5 2021-09-19 10:05:17 PDT
<rdar://problem/83285459>
Antti Koivisto
Comment 6 2021-09-19 10:33:27 PDT
Also makes patches collide less.
Note You need to log in before you can comment on or make changes to this bug.