Bug 230448 - Handle CSSOM style mutation of font-palette-values
Summary: Handle CSSOM style mutation of font-palette-values
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks: 230446
  Show dependency tree / graph
 
Reported: 2021-09-18 14:14 PDT by Myles C. Maxfield
Modified: 2021-09-24 02:12 PDT (History)
11 users (show)

See Also:

Attachments
Patch (10.29 KB, patch)
2021-09-23 01:01 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
WIP (15.93 KB, patch)
2021-09-23 20:06 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (17.64 KB, patch)
2021-09-23 20:51 PDT, Myles C. Maxfield 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2021-09-18 14:14:07 PDT 
... as well as handling entire rules being deleted/added.
Comment 1 Myles C. Maxfield 2021-09-20 23:18:28 PDT 
https://github.com/w3c/csswg-drafts/issues/6645
Comment 2 Radar WebKit Bug Importer 2021-09-21 01:09:10 PDT 
<rdar://problem/83343481>
Comment 3 Myles C. Maxfield 2021-09-23 00:14:39 PDT 
CSSSegmentedFontFace::fontRanges()'s cache doesn't handle the palettes
Comment 4 Myles C. Maxfield 2021-09-23 00:20:03 PDT 
For some reason a stale value is being used in CSSFontAccessor.
Comment 5 Myles C. Maxfield 2021-09-23 00:23:35 PDT 
Whoops, scratch that last comment.
Comment 7 Myles C. Maxfield 2021-09-23 01:01:59 PDT 
Created attachment 439018 [details]
Patch

Working on tests at https://github.com/litherum/wpt/commit/c9abc7278d6acdfbc3f5655653508cffd3f60b19
Comment 8 EWS Watchlist 2021-09-23 01:03:08 PDT 
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Comment 9 Myles C. Maxfield 2021-09-23 20:06:57 PDT 
Created attachment 439119 [details]
WIP
Comment 10 Myles C. Maxfield 2021-09-23 20:18:37 PDT 
WPT PR for tests at https://github.com/web-platform-tests/wpt/pull/30939
Comment 11 Myles C. Maxfield 2021-09-23 20:51:51 PDT 
Created attachment 439120 [details]
Patch
Comment 12 Myles C. Maxfield 2021-09-24 01:39:21 PDT 
https://drafts.csswg.org/css-fonts-4/#font-face-src-parsing

<font-technology> = [features(<font-feature-technology>) | variations
| color(<color-font-technology>) | palettes
| incremental ]
Comment 13 Myles C. Maxfield 2021-09-24 01:40:14 PDT 
Whoops, disregard that last comment, it's meant for a different bug.
Comment 14 EWS 2021-09-24 01:48:55 PDT 
Committed r283031 (242091@main): <https://commits.webkit.org/242091@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 439120 [details].