Bug 230430 – [ macOS Release ] TestWebKitAPI.NetworkProcess.BroadcastChannelCrashRecovery is flaky timing out

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

TestWebKitAPI.NetworkProcess.BroadcastChannelCrashRecovery

Is flaky timing out on macOS.

History: [ macOS ] TestWebKitAPI.NetworkProcess.BroadcastChannelCrashRecovery is flaky timing out 

Build page: https://build.webkit.org/#/builders/70/builds/5212

It looks like the test has been flaky since it was added at https://trac.webkit.org/changeset/282483/webkit

[Radar WebKit Bug Importer]

<rdar://problem/83256307>

History: https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.NetworkProcess.BroadcastChannelCrashRecovery

I was not able to reproduce the timeout using run-api-tests TestWebKitAPI.NetworkProcess.BroadcastChannelCrashRecovery --iterations 50

[Chris Dumez]

Created attachment 438535 [details]
Patch

[Chris Dumez]

(In reply to ayumi_kojima from comment #4)
> I was not able to reproduce the timeout using run-api-tests
> TestWebKitAPI.NetworkProcess.BroadcastChannelCrashRecovery --iterations 50

Me neither so my fix is speculative.

[Alex Christensen]

Comment on attachment 438535 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438535&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm:228
> +    TestWebKitAPI::Util::run(&finishedRunningScript);

TestWKWebView has objectByEvaluatingJavaScript which does this.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm:241
> +    } while (!canSecondWebViewSeeNewCookie);

It should only take one try.

[Chris Dumez]

Comment on attachment 438535 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438535&action=review

>> Tools/TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm:228
>> +    TestWebKitAPI::Util::run(&finishedRunningScript);
> 
> TestWKWebView has objectByEvaluatingJavaScript which does this.

Oh, I'll look into it, thanks.

>> Tools/TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm:241
>> +    } while (!canSecondWebViewSeeNewCookie);
> 
> It should only take one try.

That's definitely not true in practice. I don't know what would guarantee that.

[Chris Dumez]

Created attachment 438536 [details]
Patch

[EWS]

Committed r282719 (241856@main): <https://commits.webkit.org/241856@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 438536 [details].