Bug 230424 - [Cocoa] Make AVSampleBufferVideoOutput support an Experimental Feature
Summary: [Cocoa] Make AVSampleBufferVideoOutput support an Experimental Feature
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-09-17 13:15 PDT by Jer Noble
Modified: 2021-09-20 09:52 PDT (History)
9 users (show)

See Also:

Attachments
Patch (8.83 KB, patch)
2021-09-17 13:19 PDT, Jer Noble 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (10.40 KB, patch)
2021-09-17 14:02 PDT, Jer Noble 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (10.25 KB, patch)
2021-09-17 14:30 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (10.18 KB, patch)
2021-09-19 14:48 PDT, Jer Noble 		eric.carlson: review+
Details | Formatted Diff | Diff
Patch for landing (10.18 KB, patch)
2021-09-20 08:54 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2021-09-17 13:15:36 PDT 
[Cocoa] Make AVSampleBufferVideoOutput support an Experimental Feature
Comment 1 Jer Noble 2021-09-17 13:19:29 PDT 
Created attachment 438507 [details]
Patch
Comment 2 Jer Noble 2021-09-17 14:02:12 PDT 
Created attachment 438514 [details]
Patch
Comment 3 Jer Noble 2021-09-17 14:30:30 PDT 
Created attachment 438516 [details]
Patch
Comment 4 Radar WebKit Bug Importer 2021-09-17 15:36:29 PDT 
<rdar://problem/83258211>
Comment 5 Jer Noble 2021-09-19 14:48:44 PDT 
Created attachment 438624 [details]
Patch
Comment 6 Eric Carlson 2021-09-20 08:51:32 PDT 
Comment on attachment 438624 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438624&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:920
> +    return MediaSessionManagerCocoa::mediaSourceInlinePaintingEnabled() && PAL::getAVSampleBufferVideoOutputClass;

Shouldn't this be `PAL::getAVSampleBufferVideoOutputClass()`?
Comment 7 Jer Noble 2021-09-20 08:52:22 PDT 
(In reply to Eric Carlson from comment #6)
> Comment on attachment 438624 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=438624&action=review
> 
> > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:920
> > +    return MediaSessionManagerCocoa::mediaSourceInlinePaintingEnabled() && PAL::getAVSampleBufferVideoOutputClass;
> 
> Shouldn't this be `PAL::getAVSampleBufferVideoOutputClass()`?

Oof. Yes it should be.
Comment 8 Jer Noble 2021-09-20 08:54:13 PDT 
Created attachment 438684 [details]
Patch for landing
Comment 9 EWS 2021-09-20 09:52:50 PDT 
Committed r282752 (241889@main): <https://commits.webkit.org/241889@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 438684 [details].