Bug 230423 - [ Catalina+ Win WK1 ] http/tests/misc/iframe-reparenting-id-collision.html is a flaky text failure
Summary: [ Catalina+ Win WK1 ] http/tests/misc/iframe-reparenting-id-collision.html is...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
Keywords: InRadar
Depends on:
Reported: 2021-09-17 12:54 PDT by Robert Jenner
Modified: 2021-09-17 17:39 PDT (History)
8 users (show)

See Also:

Patch (2.05 KB, patch)
2021-09-17 15:49 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Jenner 2021-09-17 12:54:16 PDT

is a flaky text failure when running on WK1 for Windows and Catalina+


--- /Volumes/Data/worker/catalina-release-tests-wk1/build/layout-test-results/http/tests/misc/iframe-reparenting-id-collision-expected.txt
+++ /Volumes/Data/worker/catalina-release-tests-wk1/build/layout-test-results/http/tests/misc/iframe-reparenting-id-collision-actual.txt
@@ -5,4 +5,6 @@
 Beginning adoption sequence.
 PASS: adopted node without id collision
 PASS: adopted back to original page without id collision
+Started loading iframe XHR request.
+Beginning adoption sequence.
Comment 1 Radar WebKit Bug Importer 2021-09-17 13:01:33 PDT
Comment 2 Robert Jenner 2021-09-17 13:03:16 PDT
I was able to easily reproduce this at Production ToT using the following test:

run-webkit-tests http/tests/misc/iframe-reparenting-id-collision.html --iterations 10 -1
Comment 3 Robert Jenner 2021-09-17 14:29:51 PDT
I was able to reproduce the failure back to r282609. I then checked out my local repository to r282607, and ran the test again on the same revision, and it was not reproducible at that point.  

I even took --iterations up to 1000, and was not able to reproduce the failure with my local checkout at r282607, while running tests on r282609. 

So it appears that r282609 introduced the flaky failure.
Comment 4 Chris Dumez 2021-09-17 15:49:20 PDT
Created attachment 438524 [details]
Comment 5 Geoffrey Garen 2021-09-17 15:56:04 PDT
Comment on attachment 438524 [details]

Comment 6 EWS 2021-09-17 17:39:39 PDT
Committed r282716 (241853@main): <https://commits.webkit.org/241853@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 438524 [details].