Bug 230422 - Add CustomToJSObject wrapper for CSSStyleValueCustom
Summary: Add CustomToJSObject wrapper for CSSStyleValueCustom
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Qiaosong Zhou
URL:
Keywords: InRadar
Depends on:
Blocks: 175733
  Show dependency tree / graph
 
Reported: 2021-09-17 12:51 PDT by Qiaosong Zhou
Modified: 2021-09-17 16:16 PDT (History)
8 users (show)

See Also:

Attachments
Patch (3.41 KB, patch)
2021-09-17 12:52 PDT, Qiaosong Zhou 		no flags Details | Formatted Diff | Diff
Patch (3.39 KB, patch)
2021-09-17 13:46 PDT, Qiaosong Zhou 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Qiaosong Zhou 2021-09-17 12:51:24 PDT 
Add CustomToJSObject wrapper for CSSStyleValueCustom
Comment 1 Qiaosong Zhou 2021-09-17 12:52:09 PDT 
Created attachment 438505 [details]
Patch
Comment 2 Alex Christensen 2021-09-17 12:59:13 PDT 
Comment on attachment 438505 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438505&action=review

> Source/WebCore/bindings/js/JSCSSStyleValueCustom.cpp:50
> +    if (is<CSSUnparsedValue>(value))

Can this use a switch statement instead?  switch(value->getType())
That way if someone adds more it'll be a compiler error instead of searching for the places they forgot to add code.
Comment 3 Qiaosong Zhou 2021-09-17 13:46:16 PDT 
Created attachment 438511 [details]
Patch
Comment 4 EWS 2021-09-17 16:15:53 PDT 
Committed r282706 (241843@main): <https://commits.webkit.org/241843@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 438511 [details].
Comment 5 Radar WebKit Bug Importer 2021-09-17 16:16:24 PDT 
<rdar://problem/83259645>