Bug 23040 – Add fixedLayoutSize feature to ScrollView for real desktop layout within small viewport

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Adam Treat]

Hi,

Attached you'll find a patch that introduces a new fixedLayoutSize feature to the cross-platform ScrollView class in WebCore.  Together with full page zoom this feature enables WebKit to draw a web page with a desktop-like layout within a small viewport.

To take advantage of this feature the various ports need to introduce some kind of API to set the fixedLayoutSize and enable the feature.  Attached is a patch for the Qt port to do exactly this.

I will also attach patches for the Gtk and Windows ports to build with this feature as it required changes to a method in FrameLoaderClient.

Cheers,

Adam

[Adam Treat]

Created attachment 26317 [details]
fixedLayoutSize feature

The initial feature patch

[Adam Treat]

Created attachment 26318 [details]
Fixes qt port to build with fixedLayoutSize

Makes the qt port build with feature and adds API to take advantage of the feature

[Adam Treat]

Created attachment 26319 [details]
Fixes gtk port to build with feature

Fixes gtk port to build with feature

[Adam Treat]

Created attachment 26320 [details]
Fixes win port to build with feature

Fixes win port to build with feature

[Antti Koivisto]

I like the idea. 

Some tests would be cool. This could be enabled in drt for all platforms reducing risk of breaking the feature on platforms that have visibleSize==layoutSize (which is most of them).

[Adam Treat]

I would like to add tests, but to do so for all platforms will require me to add API to all of those platforms to allow setFixedLayoutSize and setUseFixedLayoutSize.  The implementation in LayoutTestController would be up to each platform and as such would require each platform to be able to modify those settings on the ScrollView which would require exposing them in each port's API.

I would do this, but unfortunately I don't have a mac and setting up for apple's windows port is difficult for me.  Please advise.

[George Staikos]

Comment on attachment 26317 [details]
fixedLayoutSize feature

Needs layout test first.

[Adam Treat]

Created attachment 26375 [details]
New version of fixedLayoutSize which fixes up Scrollview setters

[Adam Treat]

Created attachment 26376 [details]
New version of the qt API to support which includes layout test

[George Staikos]

Comment on attachment 26375 [details]
New version of fixedLayoutSize which fixes up Scrollview setters

Why is this patch the same as 26376?

[Adam Treat]

Created attachment 26379 [details]
Even newer version of fixedLayoutSize... previous was mixed up

[George Staikos]

Don't see any negative feedback, only positive, and I'm happy with it now.