Bug 230398 - [LFC][Integration] Add some useful functions to iterators
Summary: [LFC][Integration] Add some useful functions to iterators
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antti Koivisto
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-09-17 05:01 PDT by Antti Koivisto
Modified: 2021-09-17 08:02 PDT (History)
11 users (show)

See Also:


Attachments
Patch (13.68 KB, patch)
2021-09-17 05:04 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff
Patch (12.93 KB, patch)
2021-09-17 07:28 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2021-09-17 05:01:28 PDT
For future use
Comment 1 Antti Koivisto 2021-09-17 05:04:42 PDT
Created attachment 438462 [details]
Patch
Comment 2 zalan 2021-09-17 06:23:07 PDT
Comment on attachment 438462 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438462&action=review

> Source/WebCore/layout/integration/LayoutIntegrationRunIteratorModernPath.h:138
> +    enum class HyphenMode { Include, Ignore };
> +    TextRun createTextRun(HyphenMode hyphenMode = HyphenMode::Include) const

How does the caller decide whether it needs hyphen or not (as this decision is mostly driven by line breaking and the run already includes it In ::renderedContent())
Comment 3 Antti Koivisto 2021-09-17 07:12:24 PDT
> How does the caller decide whether it needs hyphen or not (as this decision
> is mostly driven by line breaking and the run already includes it In
> ::renderedContent())

You are right, kept the argument version internal and only exposed a version without any.
Comment 4 Antti Koivisto 2021-09-17 07:28:16 PDT
Created attachment 438473 [details]
Patch
Comment 5 EWS 2021-09-17 08:01:07 PDT
Committed r282661 (241802@main): <https://commits.webkit.org/241802@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 438473 [details].
Comment 6 Radar WebKit Bug Importer 2021-09-17 08:02:21 PDT
<rdar://problem/83241151>