Bug 230393 - [JSC] Add fast property enumeration mode for JSON.stringify
Summary: [JSC] Add fast property enumeration mode for JSON.stringify
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-09-17 01:35 PDT by Yusuke Suzuki
Modified: 2021-09-17 16:18 PDT (History)
12 users (show)

See Also:

Attachments
Patch (10.91 KB, patch)
2021-09-17 01:35 PDT, Yusuke Suzuki 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (10.91 KB, patch)
2021-09-17 01:36 PDT, Yusuke Suzuki 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (18.69 KB, patch)
2021-09-17 01:51 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (21.77 KB, patch)
2021-09-17 03:49 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (24.59 KB, patch)
2021-09-17 04:53 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (30.29 KB, patch)
2021-09-17 12:41 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (30.50 KB, patch)
2021-09-17 12:51 PDT, Yusuke Suzuki 		mark.lam: review+
Details | Formatted Diff | Diff
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2021-09-17 01:35:08 PDT 
[JSC] Add fast property enumeration mode for JSON.stringify
Comment 1 Yusuke Suzuki 2021-09-17 01:35:48 PDT 
Created attachment 438450 [details]
Patch
Comment 2 Yusuke Suzuki 2021-09-17 01:36:55 PDT 
Created attachment 438451 [details]
Patch
Comment 3 Yusuke Suzuki 2021-09-17 01:51:18 PDT 
Created attachment 438452 [details]
Patch
Comment 4 Yusuke Suzuki 2021-09-17 03:49:30 PDT 
Created attachment 438459 [details]
Patch
Comment 5 Yusuke Suzuki 2021-09-17 04:53:48 PDT 
Created attachment 438461 [details]
Patch
Comment 6 Yusuke Suzuki 2021-09-17 12:41:00 PDT 
Created attachment 438503 [details]
Patch
Comment 7 Yusuke Suzuki 2021-09-17 12:51:01 PDT 
Created attachment 438504 [details]
Patch
Comment 8 Mark Lam 2021-09-17 14:58:40 PDT 
Comment on attachment 438504 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438504&action=review

r=me

> Source/JavaScriptCore/ChangeLog:10
> +        This patch adds fast object property enumeration. When we know that source object has some conditions, we can say that,

I suggest "has some conditions" ==> "meets some conditions".

> Source/JavaScriptCore/runtime/JSONObject.cpp:96
> +        bool isFastObjectProperties() const { return m_isFastObjectProperties; }

nit: let's rename these to `hasFastObjectProperties()` and `m_hasFastObjectProperties`.
Comment 9 Yusuke Suzuki 2021-09-17 16:12:59 PDT 
Comment on attachment 438504 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438504&action=review

Thanks!

>> Source/JavaScriptCore/ChangeLog:10
>> +        This patch adds fast object property enumeration. When we know that source object has some conditions, we can say that,
> 
> I suggest "has some conditions" ==> "meets some conditions".

Fixed.

>> Source/JavaScriptCore/runtime/JSONObject.cpp:96
>> +        bool isFastObjectProperties() const { return m_isFastObjectProperties; }
> 
> nit: let's rename these to `hasFastObjectProperties()` and `m_hasFastObjectProperties`.

Changed.
Comment 10 Yusuke Suzuki 2021-09-17 16:17:31 PDT 
Committed r282707 (241844@main): <https://commits.webkit.org/241844@main>
Comment 11 Radar WebKit Bug Importer 2021-09-17 16:18:19 PDT 
<rdar://problem/83259718>