Bug 230377 - Avoid emitting unnecessary write barriers for PutByVal and PutPrivateName
Summary: Avoid emitting unnecessary write barriers for PutByVal and PutPrivateName
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Justin Michaud
URL:
Keywords: InRadar
Depends on: 230378
Blocks:
  Show dependency tree / graph
 
Reported: 2021-09-16 15:37 PDT by Justin Michaud
Modified: 2024-04-08 13:37 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Michaud 2021-09-16 15:37:53 PDT 
This bug would disclose a security issue, and so I chose to also categorize it as security.

We should avoid emitting write barriers when they are not needed, for example when we do not touch the butterfly. An example of this is a PutPrivateName that is not a define and has a non-cell value.

See DFGStoreBarrierInsertionPhase FIXMEs for PutByVal and PutPrivateName.
Comment 1 Radar WebKit Bug Importer 2021-09-16 15:38:07 PDT 
<rdar://problem/83216483>
Comment 2 Justin Michaud 2024-04-08 13:37:30 PDT 
Closing old bugs assigned to me