Bug 230356 - DumpRenderTree should clear a WebHTMLView static variable between tests
Summary: DumpRenderTree should clear a WebHTMLView static variable between tests
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-09-16 09:55 PDT by Simon Fraser (smfr)
Modified: 2021-09-23 17:53 PDT (History)
4 users (show)

See Also:

Attachments
Patch (4.51 KB, patch)
2021-09-16 09:56 PDT, Simon Fraser (smfr) 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (4.54 KB, patch)
2021-09-16 10:02 PDT, Simon Fraser (smfr) 		simon.fraser: review?
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2021-09-16 09:55:34 PDT 
DumpRenderTree should clear a WebHTMLView static variable between tests
Comment 1 Simon Fraser (smfr) 2021-09-16 09:56:25 PDT 
Created attachment 438358 [details]
Patch
Comment 2 Simon Fraser (smfr) 2021-09-16 09:57:28 PDT 
I did see behavior differences when debugging the failures in 230295 related to this static, but I don't know if this fixes any WK1 flakiness.
Comment 3 Simon Fraser (smfr) 2021-09-16 10:02:45 PDT 
Created attachment 438360 [details]
Patch
Comment 4 Alexey Proskuryakov 2021-09-16 11:45:41 PDT 
Comment on attachment 438360 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438360&action=review

> Source/WebKitLegacy/mac/ChangeLog:8
> +        Add testing-only SPI to clear the 'lastHitView' static in WebHTMLView.

We navigate to about:blank between tests; should this not clear lastHitView?
Comment 5 Simon Fraser (smfr) 2021-09-16 12:02:30 PDT 
It does not.
Comment 6 Alexey Proskuryakov 2021-09-16 18:02:54 PDT 
Should it though? That seems like it may be a better fix than a test-only SPI.
Comment 7 Simon Fraser (smfr) 2021-09-16 19:11:20 PDT 
I don't want to change WebKitLegacy behavior; that's all risk and little reward.
Comment 8 Radar WebKit Bug Importer 2021-09-23 09:56:27 PDT 
<rdar://problem/83452466>
Comment 9 Alexey Proskuryakov 2021-09-23 17:53:20 PDT 
I do not object to landing this, but don't feel excited enough to r+ given that isn't known to improve anything, and fixes the issue in a "wrong" way.