Bug 230352 - Move selection gap adjustment code form LegacyRootInlineBox to RenderBlockFlow
Summary: Move selection gap adjustment code form LegacyRootInlineBox to RenderBlockFlow
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antti Koivisto
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-09-16 08:50 PDT by Antti Koivisto
Modified: 2021-09-16 22:18 PDT (History)
12 users (show)

See Also:


Attachments
Patch (13.75 KB, patch)
2021-09-16 09:27 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff
Patch (13.76 KB, patch)
2021-09-16 11:09 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff
Patch (13.76 KB, patch)
2021-09-16 11:21 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2021-09-16 08:50:22 PDT
Move code out of legacy.
Comment 1 Antti Koivisto 2021-09-16 09:27:42 PDT
Created attachment 438355 [details]
Patch
Comment 2 Antti Koivisto 2021-09-16 11:09:23 PDT
Created attachment 438372 [details]
Patch
Comment 3 EWS 2021-09-16 11:15:19 PDT
Zalan Bujtas found in /Volumes/Data/worker/Commit-Queue/build/Source/WebCore/ChangeLog does not appear to be a valid reviewer according to contributors.json.
/Volumes/Data/worker/Commit-Queue/build/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Comment 4 Antti Koivisto 2021-09-16 11:21:41 PDT
Created attachment 438374 [details]
Patch
Comment 5 EWS 2021-09-16 12:19:46 PDT
Committed r282597 (241758@main): <https://commits.webkit.org/241758@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 438374 [details].
Comment 6 Radar WebKit Bug Importer 2021-09-16 12:20:18 PDT
<rdar://problem/83208277>
Comment 7 Diego Pino 2021-09-16 22:18:23 PDT
The patch broke compilation in Ubuntu LTS/Debian bots:

https://build.webkit.org/#/builders/68/builds/6643/steps/8/logs/stdio

```
In file included from WebCore/DerivedSources/unified-sources/UnifiedSource-207b877e-7.cpp:4:
../../Source/WebCore/layout/integration/LayoutIntegrationRunIterator.cpp: In member function ‘WebCore::RenderObject::HighlightState WebCore::LayoutIntegration::PathRun::selectionState() const’:
../../Source/WebCore/layout/integration/LayoutIntegrationRunIterator.cpp:103:29: error: invalid use of incomplete type ‘class WebCore::RenderView’
  103 |         return renderer.view().selection().highlightStateForTextBox(renderer, text.selectableRange());
      |                ~~~~~~~~~~~~~^~
```

Fixed in https://trac.webkit.org/changeset/282633/webkit