Bug 230328 - Allow use of --git-index and --git-commit at the same time when using with --only-files
Summary: Allow use of --git-index and --git-commit at the same time when using with --...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-09-15 17:09 PDT by Hoa Dinh
Modified: 2021-09-16 11:09 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.80 KB, patch)
2021-09-15 17:33 PDT, Hoa Dinh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hoa Dinh 2021-09-15 17:09:45 PDT
We should we be able to use --git-index and --git-commit to asks for the list of changes between the specific commit and HEAD plus the current git index.
Since it's mainly useful in the case of --only-files, we'll allow it only for this case.
Comment 1 Hoa Dinh 2021-09-15 17:33:01 PDT
Created attachment 438308 [details]
Patch
Comment 2 EWS 2021-09-16 11:08:21 PDT
Committed r282562 (241750@main): <https://commits.webkit.org/241750@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 438308 [details].
Comment 3 Radar WebKit Bug Importer 2021-09-16 11:09:15 PDT
<rdar://problem/83205119>