Bug 230322 - Web Inspector: Regression(r279613) Audit result scope toggles are missing
Summary: Web Inspector: Regression(r279613) Audit result scope toggles are missing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Patrick Angle
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-09-15 15:06 PDT by Patrick Angle
Modified: 2021-09-16 16:06 PDT (History)
4 users (show)

See Also:

Attachments
Screenshot of Issue (1.71 MB, image/png)
2021-09-15 15:06 PDT, Patrick Angle 		no flags Details
Patch v1.0 (3.34 KB, patch)
2021-09-15 16:51 PDT, Patrick Angle 		no flags Details | Formatted Diff | Diff
Patch v1.1 (2.86 KB, patch)
2021-09-16 11:41 PDT, Patrick Angle 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Angle 2021-09-15 15:06:42 PDT 
Created attachment 438296 [details]
Screenshot of Issue

Steps to reproduce:
1. Visit nintendolife.com
2. Open Web Inspector
3. Go to the Audit tab
4. Run the accessibility audits
5. Notice that the previously present scope toggles (for showing just passes/just failures) is missing.

See attach screenshot for where they belong. Last time I went looking for these was early June.
Comment 1 Radar WebKit Bug Importer 2021-09-15 15:06:56 PDT 
<rdar://problem/83169976>
Comment 2 Patrick Angle 2021-09-15 16:51:59 PDT 
Created attachment 438303 [details]
Patch v1.0
Comment 3 Patrick Angle 2021-09-16 11:41:17 PDT 
Created attachment 438376 [details]
Patch v1.1
Comment 4 Devin Rousso 2021-09-16 15:04:08 PDT 
Comment on attachment 438376 [details]
Patch v1.1

r=me, nice fix
Comment 5 Devin Rousso 2021-09-16 15:05:01 PDT 
Comment on attachment 438376 [details]
Patch v1.1

View in context: https://bugs.webkit.org/attachment.cgi?id=438376&action=review

> Source/WebInspectorUI/ChangeLog:10
> +        navigation bars. The logic in `WI.NavigationBar.prototype._calculateMinimumWidth` remains unchanged, as we still

I wonder if instead of doing a `Math.ceil` on each item, we could just do it at the very end after the `reduce`?
Comment 6 EWS 2021-09-16 16:06:03 PDT 
Committed r282616 (241775@main): <https://commits.webkit.org/241775@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 438376 [details].