Bug 230311 - Use std::optional for truncation
Summary: Use std::optional for truncation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antti Koivisto
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-09-15 11:03 PDT by Antti Koivisto
Modified: 2021-09-16 03:33 PDT (History)
17 users (show)

See Also:

Attachments
Patch (16.00 KB, patch)
2021-09-15 11:17 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Patch (15.97 KB, patch)
2021-09-15 11:19 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Patch (16.88 KB, patch)
2021-09-16 00:35 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2021-09-15 11:03:24 PDT 
Remove constants
Comment 1 Antti Koivisto 2021-09-15 11:17:47 PDT 
Created attachment 438262 [details]
Patch
Comment 2 Antti Koivisto 2021-09-15 11:19:55 PDT 
Created attachment 438263 [details]
Patch
Comment 3 Myles C. Maxfield 2021-09-15 11:55:20 PDT 
Comment on attachment 438263 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438263&action=review

> Source/WebCore/rendering/LegacyInlineTextBox.h:70
> +    auto truncation() const { return m_truncation; }

🤯
Comment 4 Antti Koivisto 2021-09-16 00:35:17 PDT 
Created attachment 438323 [details]
Patch
Comment 5 EWS 2021-09-16 03:32:34 PDT 
Committed r282530 (241741@main): <https://commits.webkit.org/241741@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 438323 [details].
Comment 6 Radar WebKit Bug Importer 2021-09-16 03:33:33 PDT 
<rdar://problem/83190577>