Bug 23029 - REGRESSION (r39337): jsfunfuzz generates identical test files
Summary: REGRESSION (r39337): jsfunfuzz generates identical test files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2008-12-29 18:02 PST by Oliver Hunt
Modified: 2008-12-30 05:10 PST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2008-12-29 18:02:18 PST
jsfunfuzz uses Math.random() to generate random test resutls.  Prior to squirrelfish it generated different results for every test file.  Now the files are all identical

12/29/08 5:59 PM Oliver Hunt:
The unification of the random number generation in r39337 made random number generation always start with the same seed in JSC.  This is non-standard behaviour based on both our old behaviour and that of other browsers.

<rdar://problem/6469185>
Comment 1 Cameron Zwarich (cpst) 2008-12-29 21:11:49 PST
What's a good fix for this problem?
Comment 2 Oliver Hunt 2008-12-29 21:23:52 PST
Bad Niko, seeding random but then using rand()
Comment 3 Cameron Zwarich (cpst) 2008-12-29 21:39:16 PST
Fixed in r39507:

http://trac.webkit.org/changeset/39507
Comment 4 Nikolas Zimmermann 2008-12-30 05:10:52 PST
Ouch, thanks a lot for fixing Cameron :-)