Bug 230275 - [Win] JSRemoteInspector.h missing stdint include
Summary: [Win] JSRemoteInspector.h missing stdint include
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ross Kirsling
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-09-14 13:46 PDT by Ross Kirsling
Modified: 2021-09-14 15:10 PDT (History)
8 users (show)

See Also:


Attachments
Patch (1.11 KB, patch)
2021-09-14 13:46 PDT, Ross Kirsling
no flags Details | Formatted Diff | Diff
Patch (1.17 KB, patch)
2021-09-14 13:54 PDT, Ross Kirsling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ross Kirsling 2021-09-14 13:46:31 PDT
[WinCairo] Add missing include for testapi
Comment 1 Ross Kirsling 2021-09-14 13:46:49 PDT
Created attachment 438163 [details]
Patch
Comment 2 Don Olmstead 2021-09-14 13:52:54 PDT
Comment on attachment 438163 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438163&action=review

r=me with nits.

> Source/JavaScriptCore/ChangeLog:3
> +        [WinCairo] Add missing include for testapi

I would have this be [Win] JSRemoteInspector.h missing stdint include

At one point we found it with testapi but the actual reason is were missing a definition for uint8_t when including JSRemoteInspector.h on its own.

> Source/JavaScriptCore/ChangeLog:7
> +

Reason is basically "Include stdint for uint8_t definition on Windows"
Comment 3 Ross Kirsling 2021-09-14 13:54:53 PDT
Created attachment 438166 [details]
Patch
Comment 4 EWS 2021-09-14 15:09:26 PDT
Committed r282413 (241672@main): <https://commits.webkit.org/241672@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 438166 [details].
Comment 5 Radar WebKit Bug Importer 2021-09-14 15:10:16 PDT
<rdar://problem/83118735>