Bug 230263 - Cache resource paths in run-jsc-stress-tests for speedup
Summary: Cache resource paths in run-jsc-stress-tests for speedup
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-09-14 06:50 PDT by Geza Lore
Modified: 2021-09-15 12:53 PDT (History)
6 users (show)

See Also:


Attachments
Patch (1.73 KB, patch)
2021-09-14 06:55 PDT, Geza Lore
no flags Details | Formatted Diff | Diff
Patch (1.73 KB, patch)
2021-09-14 07:12 PDT, Geza Lore
no flags Details | Formatted Diff | Diff
Patch (1.73 KB, patch)
2021-09-14 07:16 PDT, Geza Lore
no flags Details | Formatted Diff | Diff
Patch (3.21 KB, patch)
2021-09-14 07:20 PDT, Geza Lore
no flags Details | Formatted Diff | Diff
Patch (1.73 KB, patch)
2021-09-14 07:23 PDT, Geza Lore
no flags Details | Formatted Diff | Diff
Patch (1.87 KB, patch)
2021-09-14 14:18 PDT, Geza Lore
no flags Details | Formatted Diff | Diff
Patch (1.78 KB, patch)
2021-09-15 01:43 PDT, Geza Lore
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Geza Lore 2021-09-14 06:50:05 PDT
Cache resource paths in run-jsc-stress-tests for speedup
Comment 1 Geza Lore 2021-09-14 06:55:37 PDT
Created attachment 438133 [details]
Patch
Comment 2 Geza Lore 2021-09-14 07:12:57 PDT
Created attachment 438136 [details]
Patch
Comment 3 Geza Lore 2021-09-14 07:16:20 PDT
Created attachment 438137 [details]
Patch
Comment 4 Geza Lore 2021-09-14 07:20:24 PDT
Created attachment 438138 [details]
Patch
Comment 5 Geza Lore 2021-09-14 07:23:17 PDT
Created attachment 438140 [details]
Patch
Comment 6 Geza Lore 2021-09-14 14:18:50 PDT
Created attachment 438170 [details]
Patch
Comment 7 Geza Lore 2021-09-15 01:43:39 PDT
Created attachment 438223 [details]
Patch
Comment 8 Geza Lore 2021-09-15 09:43:25 PDT
Comment on attachment 438223 [details]
Patch

Minor note: This is one of my first time contributions to the WebKit project, so please educate me on process if I got something wrong. The patch is hopefully uncontroversial.
Comment 9 Adrian Perez 2021-09-15 12:41:08 PDT
(In reply to Geza Lore from comment #8)
> Comment on attachment 438223 [details]
> Patch
> 
> Minor note: This is one of my first time contributions to the WebKit
> project, so please educate me on process if I got something wrong. The patch
> is hopefully uncontroversial.

The patch was all good, thanks! The most typical first-time contribution
issues are missing or badly formatted ChangeLog entries in the submitted
patches. Running `check-webkit-style` locally or looking at the messages
when the “style” EWS bubble is not green goes a long way to pave the way
=)
Comment 10 Adrian Perez 2021-09-15 12:43:34 PDT
(In reply to Adrian Perez from comment #9)
> (In reply to Geza Lore from comment #8)
> > Comment on attachment 438223 [details]
> > Patch
> > 
> > Minor note: This is one of my first time contributions to the WebKit
> > project, so please educate me on process if I got something wrong. The patch
> > is hopefully uncontroversial.
> 
> The patch was all good, thanks! The most typical first-time contribution
> issues are missing or badly formatted ChangeLog entries in the submitted
> patches. Running `check-webkit-style` locally or looking at the messages
> when the “style” EWS bubble is not green goes a long way to pave the way
> =)

If something, you could have set the cq? flag to request that the patch
gets approved for merging (“cq” stands for “commit queue“). I have set
the flag to cq+ because I assumed that you want the patch to be merged
right after getting the r+ with the approval.
Comment 11 EWS 2021-09-15 12:52:27 PDT
Committed r282465 (241713@main): <https://commits.webkit.org/241713@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 438223 [details].
Comment 12 Radar WebKit Bug Importer 2021-09-15 12:53:18 PDT
<rdar://problem/83163850>