Bug 230249 - [GTK] TestWebKitAccessibility is always skipped in the bots
Summary: [GTK] TestWebKitAccessibility is always skipped in the bots
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2021-09-14 03:16 PDT by Carlos Garcia Campos
Modified: 2021-10-19 21:08 PDT (History)
3 users (show)

See Also:


Attachments
Patch (4.59 KB, patch)
2021-09-14 03:39 PDT, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2021-09-14 03:16:40 PDT
We fail to start the a11y service under flatpak.

Failed to talk to the accessibility service: Cannot autolaunch D-Bus without X11 $DISPLAY
Could not start accessibility bus, so disabling TestWebKitAccessibility
Comment 1 Carlos Garcia Campos 2021-09-14 03:39:24 PDT
Created attachment 438120 [details]
Patch

Let's try this...
Comment 2 Carlos Garcia Campos 2021-09-14 04:02:27 PDT
Still fails :-(

Failed to talk to the accessibility service: Error spawning command line ?dbus-launch --autolaunch=18a76d89e81b4cb5aa297189e9cbb201 --binary-syntax --close-stderr?: Child process exited with code 1
Comment 3 Carlos Alberto Lopez Perez 2021-09-27 04:14:35 PDT
This seems an issue related to dbus and the configuration we currently have on the flatpak and the workers.
This is what happens:

	1. When the test runs it starts the dbus accessibility bus
	2. For starting this it looks for an already running dbus daemon
	3. On the workers it doesn't find the dbus daemon because it is not enabled for the service of the buildbot
	4. Then the test it tries to auto-start dbus by using the dbus magic auto-start feature
	5. On the dbus binary of the flatpak this magic is not enabled so it fails with this error "Autolaunch requested, but X11 support not compiled in. Cannot continue."


So we need to either:
	- Option A -> Build dbus with the autostart feature inside flatpak
	- Option B -> Start the dbus daemon if needed on the test-runner before starting the tests
	- Option C -> Ensure the workers have a running dbus daemon for the buildbot service

After discussing this with Carlos it seems that Option C seems the best one, as that is closer to the usual developer/user environment where dbus is assumed to be running and working.
I will try to deploy this on the workers.
Comment 4 Carlos Garcia Campos 2021-10-18 05:45:23 PDT
Comment on attachment 438120 [details]
Patch

This didn't fix the issue.
Comment 5 Carlos Garcia Campos 2021-10-18 05:46:43 PDT
In the end, bots have been configured to run dbus service, so tests should be running fine now.
Comment 6 Carlos Alberto Lopez Perez 2021-10-19 21:08:39 PDT
The fix applied on the bots caused timeouts on the layout tests.

There is something weird interaction happening between flatpak and XDG_RUNTIME_DIR.

This requires more investigation
Comment 7 Carlos Alberto Lopez Perez 2021-10-19 21:08:53 PDT
The previous fix was reverted for the moment