RESOLVED FIXED Bug 230248
[Cocoa] Migrate to CTFontHasTable() from CTFontCopyAvailableTables() 
https://bugs.webkit.org/show_bug.cgi?id=230248
Summary [Cocoa] Migrate to CTFontHasTable() from CTFontCopyAvailableTables()
Myles C. Maxfield
Reported 2021-09-14 01:24:09 PDT
[Cocoa] Migrate to CTFontHasTable() from CTFontCopyAvailableTables()
Attachments
Patch (5.29 KB, patch)
2021-09-14 01:25 PDT, Myles C. Maxfield 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2021-09-14 01:25:09 PDT
Created attachment 438112 [details] Patch
Anders Carlsson
Comment 2 2021-09-14 07:39:33 PDT
Comment on attachment 438112 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=438112&action=review > Source/WTF/wtf/PlatformUse.h:322 > +#define USE_CTFONTHASTABLE 1 I'd write this out as USE_CT_FONT_HAS_TABLE - but maybe that's just me!
Myles C. Maxfield
Comment 3 2021-09-14 11:33:58 PDT
Comment on attachment 438112 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=438112&action=review >> Source/WTF/wtf/PlatformUse.h:322 >> +#define USE_CTFONTHASTABLE 1 > > I'd write this out as USE_CT_FONT_HAS_TABLE - but maybe that's just me! Yeah I originally did this the first time this kind of thing came up, but someone (I forget who) told me not to. Since then, we have USE_CTFONTSHAPEGLYPHS and USE_CTFONTSHAPEGLYPHS_WORKAROUND, so it seems maybe better to follow the established pattern.
Myles C. Maxfield
Comment 4 2021-09-14 11:39:49 PDT
Comment on attachment 438112 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=438112&action=review >>> Source/WTF/wtf/PlatformUse.h:322 >>> +#define USE_CTFONTHASTABLE 1 >> >> I'd write this out as USE_CT_FONT_HAS_TABLE - but maybe that's just me! > > Yeah I originally did this the first time this kind of thing came up, but someone (I forget who) told me not to. Since then, we have USE_CTFONTSHAPEGLYPHS and USE_CTFONTSHAPEGLYPHS_WORKAROUND, so it seems maybe better to follow the established pattern. HAVE_CTFONTCREATEFORCHARACTERSWITHLANGUAGEANDOPTION, HAVE_CTFONTISSYSTEMUIFONT, HAVE_CTFONTGETPHYSICALSYMBOLICTRAITS, and USE_CTFONTGETADVANCES_WORKAROUND too.
Myles C. Maxfield
Comment 5 2021-09-14 11:42:24 PDT
Committed r282398 (241659@main): <https://commits.webkit.org/241659@main>
Radar WebKit Bug Importer
Comment 6 2021-09-14 11:43:24 PDT
<rdar://problem/83110084>
Note You need to log in before you can comment on or make changes to this bug.