Bug 230244 - Implement text-decoration-skip-ink
Summary: Implement text-decoration-skip-ink
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-09-13 21:33 PDT by Myles C. Maxfield
Modified: 2021-09-14 16:42 PDT (History)
14 users (show)

See Also:


Attachments
WIP (28.47 KB, patch)
2021-09-13 21:35 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch (88.44 KB, patch)
2021-09-14 00:41 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch (88.79 KB, patch)
2021-09-14 00:52 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch (89.57 KB, patch)
2021-09-14 02:30 PDT, Myles C. Maxfield
koivisto: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2021-09-13 21:33:35 PDT
Implement text-decoration-skip-ink
Comment 1 Myles C. Maxfield 2021-09-13 21:35:37 PDT
Created attachment 438100 [details]
WIP
Comment 2 Myles C. Maxfield 2021-09-13 23:28:35 PDT
Failing tests:

fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-roundtrip.html
imported/w3c/web-platform-tests/css/css-pseudo/parsing/marker-supported-properties-in-animation.html
imported/w3c/web-platform-tests/css/css-pseudo/parsing/marker-supported-properties.html
imported/w3c/web-platform-tests/css/css-text-decor/inheritance.html
imported/w3c/web-platform-tests/css/css-text-decor/parsing/text-decoration-skip-ink-computed.html
imported/w3c/web-platform-tests/css/css-text-decor/parsing/text-decoration-skip-ink-valid.html
imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-skip-ink.html
imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext.html
imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree.html
Comment 3 Myles C. Maxfield 2021-09-14 00:41:04 PDT
Created attachment 438109 [details]
Patch
Comment 4 Myles C. Maxfield 2021-09-14 00:52:29 PDT
Created attachment 438110 [details]
Patch
Comment 5 Myles C. Maxfield 2021-09-14 02:30:04 PDT
Created attachment 438116 [details]
Patch
Comment 6 Antti Koivisto 2021-09-14 06:27:34 PDT
Comment on attachment 438116 [details]
Patch

Seems reasonable, r=me
Comment 7 Myles C. Maxfield 2021-09-14 11:39:11 PDT
Committed r282397 (241658@main): <https://commits.webkit.org/241658@main>
Comment 8 Radar WebKit Bug Importer 2021-09-14 11:40:38 PDT
<rdar://problem/83109958>
Comment 9 Darin Adler 2021-09-14 16:42:58 PDT
Comment on attachment 438116 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438116&action=review

> Source/WebCore/css/parser/CSSPropertyParser.cpp:1681
> +    if (RefPtr<CSSPrimitiveValue> skip = consumeIdent<CSSValueNone, CSSValueAuto, CSSValueInk>(m_range)) {

auto