They weren't ever really supported, but no that they were removed from the spec, we can get rid of them completely.
Created attachment 26289 [details] proposed patch
Comment on attachment 26289 [details] proposed patch r=me. > Index: WebCore/loader/appcache/ApplicationCacheResource.h > =================================================================== > --- WebCore/loader/appcache/ApplicationCacheResource.h (revision 39497) > +++ WebCore/loader/appcache/ApplicationCacheResource.h (working copy) > @@ -40,7 +40,7 @@ public: > Explicit = 1 << 2, > Foreign = 1 << 3, > Fallback = 1 << 4, > - Opportunistic = 1 << 5, > + // Bit 5 was used for opportunistic entries, which were removed from the spec. > Dynamic = 1 << 6 You should note in the changelog the reason you can't change Dynamic to use bit-5.
Typo in ChangeLog: > Remove incomplete support for opportunistic apcache entries s/apcache/appcache/
Comment on attachment 26289 [details] proposed patch > - Opportunistic = 1 << 5, > + // Bit 5 was used for opportunistic entries, which were removed from the spec. > Dynamic = 1 << 6 > }; Why keep this comment? Why not renumber Dynamic to use bit 5?
Committed <http://trac.webkit.org/projects/webkit/changeset/39514>.
(In reply to comment #4) > Why keep this comment? Why not renumber Dynamic to use bit 5? Maybe I could do that, given that neither fallback nor dynamic entries were stored before - but I'm going to bump schema version soon, which will be a good opportunity to change this.