Bug 23022 – Fix multiple issues with appcache online whitelist handling

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Alexey Proskuryakov]

Patch forthcoming.

[Alexey Proskuryakov]

Created attachment 26288 [details]
proposed patch

[Darin Adler]

Comment on attachment 26288 [details]
proposed patch

> +    unsigned whitelistSize = m_onlineWhitelist.size();
> +    for (unsigned i = 0; i < whitelistSize; ++i) {

We normally use size_t to iterate vectors.

> +        unsigned whitelistSize = onlineWhitelist.size();
> +        for (unsigned i = 0; i < whitelistSize; ++i) {

Ditto.

For scaling, with large whitelists, it seems we might want to come up with a hash function so we can use a hashed set rather than a vector.

> +# This should work normally.
> +counter.php?uncached
> \ No newline at end of file

Can we add a newline?

r=me

[Alexey Proskuryakov]

(In reply to comment #2)
> For scaling, with large whitelists, it seems we might want to come up with a
> hash function so we can use a hashed set rather than a vector.

I'm not aware of any way to use a hash function for prefix matching. We could use a tree though.

But I doubt that whitelists will be very large.

> > +# This should work normally.
> > +counter.php?uncached
> > \ No newline at end of file
> 
> Can we add a newline?

I didn't add it intentionally - I wanted to have a test for parsing such a manifest.

[Alexey Proskuryakov]

Committed revision 39548.