Bug 230219 – Refactor WritableStream to better integrate https://streams.spec.whatwg.org/#create-writable-stream

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[youenn fablet]

Refactor WritableStream to better integrate https://streams.spec.whatwg.org/#create-writable-stream

[Radar WebKit Bug Importer]

<rdar://problem/83055758>

[youenn fablet]

Created attachment 438041 [details]
Patch

[Sihui Liu]

Comment on attachment 438041 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438041&action=review

r=me, if all bots are green

> Source/WebCore/ChangeLog:9
> +        we were still going through the WritableStream constructor taking an underlying source.

underlying sink?

> Source/WebCore/Modules/streams/WritableStreamInternals.js:51
> +    const internalStream = { };

Do we want to Assert: ! IsNonNegativeNumber(highWaterMark) is true as spec?

[youenn fablet]

Created attachment 438132 [details]
Patch for landing

[youenn fablet]

Thanks for the review.

(In reply to Sihui Liu from comment #3)
> Comment on attachment 438041 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=438041&action=review
> 
> r=me, if all bots are green
> 
> > Source/WebCore/ChangeLog:9
> > +        we were still going through the WritableStream constructor taking an underlying source.
> 
> underlying sink?

Done.

> > Source/WebCore/Modules/streams/WritableStreamInternals.js:51
> > +    const internalStream = { };
> 
> Do we want to Assert: ! IsNonNegativeNumber(highWaterMark) is true as spec?

Added, I had to fix an actual bug in extractHWM.

[EWS]

Committed r282395 (241656@main): <https://commits.webkit.org/241656@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 438132 [details].