Refactor WritableStream to better integrate https://streams.spec.whatwg.org/#create-writable-stream
<rdar://problem/83055758>
Created attachment 438041 [details] Patch
Comment on attachment 438041 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=438041&action=review r=me, if all bots are green > Source/WebCore/ChangeLog:9 > + we were still going through the WritableStream constructor taking an underlying source. underlying sink? > Source/WebCore/Modules/streams/WritableStreamInternals.js:51 > + const internalStream = { }; Do we want to Assert: ! IsNonNegativeNumber(highWaterMark) is true as spec?
Created attachment 438132 [details] Patch for landing
Thanks for the review. (In reply to Sihui Liu from comment #3) > Comment on attachment 438041 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=438041&action=review > > r=me, if all bots are green > > > Source/WebCore/ChangeLog:9 > > + we were still going through the WritableStream constructor taking an underlying source. > > underlying sink? Done. > > Source/WebCore/Modules/streams/WritableStreamInternals.js:51 > > + const internalStream = { }; > > Do we want to Assert: ! IsNonNegativeNumber(highWaterMark) is true as spec? Added, I had to fix an actual bug in extractHWM.
Committed r282395 (241656@main): <https://commits.webkit.org/241656@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 438132 [details].