Bug 230195 – Provide a way to update the commit message with an updated list of changed files/functions

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Hoa Dinh]

When the author needs to make additional changes to the commit, we generally need to make changes to the commit message with the updated list with changes in files/functions.
Currently, that process is very manual and may involve:
- saving the current commit message un-committing then re-committing and merge the old commit message with the new generated commit message template.
- or writing manually the list of new changes in files/functions.

This process should be a little more automated.

For that, we can make changes in commit-log-editor to allow updates of the commit message with a generated list of changed files/functions.
Since there may already be comment of the author or this list of files/functions, this updated list needs to be appended at the bottom for the author to merge the content.

[Hoa Dinh]

Created attachment 437967 [details]
Patch

[Hoa Dinh]

Created attachment 437969 [details]
Patch

[Hoa Dinh]

Created attachment 438083 [details]
Patch

[Jonathan Bedard]

Comment on attachment 438083 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438083&action=review

> Tools/Scripts/prepare-ChangeLog:183
> +        print STDERR "  --only-files    Generate only the files changes.\n";

I would change this to say "Exclude the standard changelog header and only include references to files", the existing message doesn't give much extra information.

[Hoa Dinh]

Created attachment 438088 [details]
Patch

[Hoa Dinh]

I added that part:


-        my $date = changeLogDate(ChangeLogTimeZone);
-        print CHANGE_LOG normalizeLineEndings("$date  $name  <$emailAddress>\n\n", $endl);
+        if (!$onlyFiles) {
+            my $date = changeLogDate(ChangeLogTimeZone);
+            print CHANGE_LOG normalizeLineEndings("$date  $name  <$emailAddress>\n\n", $endl);
+        }

And also applied the suggestion for the help message.

[Hoa Dinh]

cq?

[Fujii Hironori]

Do yuou know "Tools/Scripts/webkit-patch prepare --update-changelogs <BUG_ID>"?

[EWS]

Committed r282391 (241652@main): <https://commits.webkit.org/241652@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 438088 [details].

[Radar WebKit Bug Importer]

<rdar://problem/83104345>