RESOLVED FIXED 230191
Add unit test that uses PCM daemon 
https://bugs.webkit.org/show_bug.cgi?id=230191
Summary Add unit test that uses PCM daemon
Alex Christensen
Reported 2021-09-11 10:53:39 PDT
Add unit test that uses PCM daemon
Attachments
Patch (49.55 KB, patch)
2021-09-11 10:57 PDT, Alex Christensen 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (51.88 KB, patch)
2021-09-11 12:11 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (52.07 KB, patch)
2021-09-11 21:17 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (55.75 KB, patch)
2021-09-13 11:12 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (55.74 KB, patch)
2021-09-13 14:24 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (55.74 KB, patch)
2021-09-13 14:25 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2021-09-11 10:57:44 PDT
Created attachment 437959 [details] Patch
Alex Christensen
Comment 2 2021-09-11 12:11:26 PDT
Created attachment 437962 [details] Patch
Alex Christensen
Comment 3 2021-09-11 21:17:12 PDT
Created attachment 437979 [details] Patch
Alex Christensen
Comment 4 2021-09-13 11:12:55 PDT
Created attachment 438057 [details] Patch
Chris Dumez
Comment 5 2021-09-13 12:39:53 PDT
Comment on attachment 438057 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=438057&action=review > Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementConnection.h:45 > + Connection(CString&& machServiceName); explicit > Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementConnection.h:53 > + const CString m_machServiceName; Would be nice to have a blank line to separate data members from member functions. > Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementManagerProxy.cpp:75 > + : m_connection(machServiceName.utf8()) { } Don't we usually put the { } on the next line?
Alex Christensen
Comment 6 2021-09-13 12:41:51 PDT
Comment on attachment 438057 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=438057&action=review >> Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementManagerProxy.cpp:75 >> + : m_connection(machServiceName.utf8()) { } > > Don't we usually put the { } on the next line? This is more and more common in WebKit when constructors don't do anything except initialize member variables.
Alex Christensen
Comment 7 2021-09-13 14:24:07 PDT
Created attachment 438077 [details] Patch
Alex Christensen
Comment 8 2021-09-13 14:25:07 PDT
Created attachment 438078 [details] Patch
Alex Christensen
Comment 9 2021-09-13 15:36:37 PDT
r282368
Alex Christensen
Comment 10 2021-09-29 22:01:10 PDT
http://trac.webkit.org/r283298
Radar WebKit Bug Importer
Comment 11 2021-09-29 22:02:17 PDT
<rdar://problem/83703571>
Alex Christensen
Comment 12 2021-09-30 21:15:04 PDT
r283357
Note You need to log in before you can comment on or make changes to this bug.