Bug 230191 - Add unit test that uses PCM daemon
Summary: Add unit test that uses PCM daemon
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-09-11 10:53 PDT by Alex Christensen
Modified: 2021-09-30 21:15 PDT (History)
5 users (show)

See Also:

Attachments
Patch (49.55 KB, patch)
2021-09-11 10:57 PDT, Alex Christensen 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (51.88 KB, patch)
2021-09-11 12:11 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (52.07 KB, patch)
2021-09-11 21:17 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (55.75 KB, patch)
2021-09-13 11:12 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (55.74 KB, patch)
2021-09-13 14:24 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (55.74 KB, patch)
2021-09-13 14:25 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2021-09-11 10:53:39 PDT 
Add unit test that uses PCM daemon
Comment 1 Alex Christensen 2021-09-11 10:57:44 PDT 
Created attachment 437959 [details]
Patch
Comment 2 Alex Christensen 2021-09-11 12:11:26 PDT 
Created attachment 437962 [details]
Patch
Comment 3 Alex Christensen 2021-09-11 21:17:12 PDT 
Created attachment 437979 [details]
Patch
Comment 4 Alex Christensen 2021-09-13 11:12:55 PDT 
Created attachment 438057 [details]
Patch
Comment 5 Chris Dumez 2021-09-13 12:39:53 PDT 
Comment on attachment 438057 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438057&action=review

> Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementConnection.h:45
> +    Connection(CString&& machServiceName);

explicit

> Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementConnection.h:53
> +    const CString m_machServiceName;

Would be nice to have a blank line to separate data members from member functions.

> Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementManagerProxy.cpp:75
> +    : m_connection(machServiceName.utf8()) { }

Don't we usually put the { } on the next line?
Comment 6 Alex Christensen 2021-09-13 12:41:51 PDT 
Comment on attachment 438057 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438057&action=review

>> Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementManagerProxy.cpp:75
>> +    : m_connection(machServiceName.utf8()) { }
> 
> Don't we usually put the { } on the next line?

This is more and more common in WebKit when constructors don't do anything except initialize member variables.
Comment 7 Alex Christensen 2021-09-13 14:24:07 PDT 
Created attachment 438077 [details]
Patch
Comment 8 Alex Christensen 2021-09-13 14:25:07 PDT 
Created attachment 438078 [details]
Patch
Comment 9 Alex Christensen 2021-09-13 15:36:37 PDT 
r282368
Comment 10 Alex Christensen 2021-09-29 22:01:10 PDT 
http://trac.webkit.org/r283298
Comment 11 Radar WebKit Bug Importer 2021-09-29 22:02:17 PDT 
<rdar://problem/83703571>
Comment 12 Alex Christensen 2021-09-30 21:15:04 PDT 
r283357