Bug 230190 - Linker warnings for WKWebViewConfiguration.limitsNavigationsToAppBoundDomains property methods
Summary: Linker warnings for WKWebViewConfiguration.limitsNavigationsToAppBoundDomains...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on: 210620
Blocks:
  Show dependency tree / graph
 
Reported: 2021-09-11 10:49 PDT by David Kilzer (:ddkilzer)
Modified: 2021-09-13 10:02 PDT (History)
4 users (show)

See Also:

Attachments
Patch v1 (2.55 KB, patch)
2021-09-11 10:52 PDT, David Kilzer (:ddkilzer) 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch v2 (2.55 KB, patch)
2021-09-11 11:56 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2021-09-11 10:49:48 PDT 
Linker warnings for WKWebViewConfiguration.limitsNavigationsToAppBoundDomains property methods when building for iOS:

ld: warning: method '-limitsNavigationsToAppBoundDomains' in category from WebKitBuild/WebKit.build/Release-iphoneos/WebKit.build/Objects-normal/arm64e/UnifiedSource25-mm.o overrides method from class in WebKitBuild/WebKit.build/Release-iphoneos/WebKit.build/Objects-normal/arm64e/UnifiedSource25-mm.o
ld: warning: method '-setLimitsNavigationsToAppBoundDomains:' in category from WebKitBuild/WebKit.build/Release-iphoneos/WebKit.build/Objects-normal/arm64e/UnifiedSource25-mm.o overrides method from class in WebKitBuild/WebKit.build/Release-iphoneos/WebKit.build/Objects-normal/arm64e/UnifiedSource25-mm.o

This happens because the methods are implemented in category WKWebViewConfiguration (WKPrivate), but should be moved to WKWebViewConfiguration since the property was added as API in r260228.
Comment 1 David Kilzer (:ddkilzer) 2021-09-11 10:52:53 PDT 
Created attachment 437958 [details]
Patch v1
Comment 2 David Kilzer (:ddkilzer) 2021-09-11 11:07:30 PDT 
Comment on attachment 437958 [details]
Patch v1

This needs PLATFORM(IOS) guards.
Comment 3 David Kilzer (:ddkilzer) 2021-09-11 11:56:57 PDT 
Created attachment 437961 [details]
Patch v2
Comment 4 Kate Cheney 2021-09-12 19:39:23 PDT 
Comment on attachment 437961 [details]
Patch v2

r=me
Comment 5 EWS 2021-09-13 10:01:24 PDT 
Committed r282332 (241600@main): <https://commits.webkit.org/241600@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 437961 [details].
Comment 6 Radar WebKit Bug Importer 2021-09-13 10:02:22 PDT 
<rdar://problem/83060079>