Bug 230183 - [PlayStation][MiniBrowser] Remove WebKit private header include
Summary: [PlayStation][MiniBrowser] Remove WebKit private header include
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yoshiaki Jitsukawa
Keywords: InRadar
Depends on:
Reported: 2021-09-10 17:08 PDT by Yoshiaki Jitsukawa
Modified: 2021-09-21 14:09 PDT (History)
3 users (show)

See Also:

Patch (1.73 KB, patch)
2021-09-10 17:14 PDT, Yoshiaki Jitsukawa
no flags Details | Formatted Diff | Diff
Patch (1.73 KB, patch)
2021-09-12 15:45 PDT, Yoshiaki Jitsukawa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yoshiaki Jitsukawa 2021-09-10 17:08:04 PDT
PlayStation MiniBrowser is expected to be independent of WebKit private headers (i.e. it should depend only on WK API.) in order to ensure that we can make a WebBrowser without those headers.
Comment 1 Yoshiaki Jitsukawa 2021-09-10 17:14:52 PDT
Created attachment 437929 [details]
Comment 2 Yoshiaki Jitsukawa 2021-09-12 15:45:11 PDT
Created attachment 437997 [details]
Comment 3 Stephan Szabo 2021-09-13 10:15:46 PDT
Seems good.

For the future, should we also be trying to remove the dependency on cmakeconfig.h?
Comment 4 Radar WebKit Bug Importer 2021-09-17 17:09:20 PDT
Comment 5 EWS 2021-09-21 14:09:20 PDT
Committed r282840 (241971@main): <https://commits.webkit.org/241971@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 437997 [details].