Bug 230159 – Send preference updates to the GPU Process

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Per Arne Vollan]

Like the WebContent process, the GPU process should also receive preference updates since it is blocking the preference service in the sandbox.

[Per Arne Vollan]

<rdar://81049367>

[Per Arne Vollan]

Created attachment 437886 [details]
Patch

[chris fleizach]

Comment on attachment 437886 [details]
Patch

AuxiliaryProcessCocoa.mm:166:1: error: extraneous closing brace ('}')

[Per Arne Vollan]

Created attachment 437891 [details]
Patch

[Per Arne Vollan]

(In reply to chris fleizach from comment #3)
> Comment on attachment 437886 [details]
> Patch
> 
> AuxiliaryProcessCocoa.mm:166:1: error: extraneous closing brace ('}')

Patch updated.

Thanks for reviewing!

[Brent Fulgham]

Comment on attachment 437891 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437891&action=review

r=me

> Source/WebKit/Shared/Cocoa/AuxiliaryProcessCocoa.mm:134
> +id AuxiliaryProcess::decodePreferenceValue(const std::optional<String>& encodedValue)

Oh, nice! We have centralized this now.

> Source/WebKit/Shared/Cocoa/AuxiliaryProcessCocoa.mm:143
> +    auto classes = [NSSet setWithArray:@[[NSString class], [NSNumber class], [NSDate class], [NSDictionary class], [NSArray class], [NSData class]]];

I wonder if there is any perf benefit to making this a "NeverDestroyed" thing, since we presumably construct this set every time we try to decode preference values.

[Per Arne Vollan]

(In reply to Brent Fulgham from comment #6)
> Comment on attachment 437891 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=437891&action=review
> 
> r=me
> 
> > Source/WebKit/Shared/Cocoa/AuxiliaryProcessCocoa.mm:134
> > +id AuxiliaryProcess::decodePreferenceValue(const std::optional<String>& encodedValue)
> 
> Oh, nice! We have centralized this now.
> 
> > Source/WebKit/Shared/Cocoa/AuxiliaryProcessCocoa.mm:143
> > +    auto classes = [NSSet setWithArray:@[[NSString class], [NSNumber class], [NSDate class], [NSDictionary class], [NSArray class], [NSData class]]];
> 
> I wonder if there is any perf benefit to making this a "NeverDestroyed"
> thing, since we presumably construct this set every time we try to decode
> preference values.

That is a good point. I think there will be a performance benefit from this, although since this should not be a hot path, I think it also could be good to avoid the small added memory cost by making this NeverDestroyed.

Thanks for reviewing!

[Per Arne Vollan]

Created attachment 438058 [details]
Patch

[EWS]

Committed r282364 (241627@main): <https://commits.webkit.org/241627@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 438058 [details].