Bug 230153 – Web Inspector: Update naming of WI.CSSCompletions callback used for collecting supported CSS properties from the target

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Razvan Caliman]

`Source/WebInspectorUI/UserInterface/Models/CSSCompletions.js:82`

The callback is confusingly named `propertyNamesCallback()` and has a `names` argument.

The payload is actually a list of objects with CSS property names, values, aliases, longhands, etc.

The constructor of `WI.CSSCompletions` expects and handles this payload.

Seems like `WI.CSSCompletions` began life handling just CSS property names, but overtime got overloaded to support additional use cases. 
For example, `WI.CSSCompletions` ends up having an instance of itself assigned as a property o_O:

```
WI.CSSCompletions.cssNameCompletions = new WI.CSSCompletions(properties, false);
```

There's a bit of confusing ping-pong between `WI.CSSCompletions` and `WI.CSSKeywordCompletions`.
But that's a fix for another patch.

[Razvan Caliman]

Created attachment 437875 [details]
Patch 1.0

[Radar WebKit Bug Importer]

<rdar://problem/82975738>

[Devin Rousso]

Comment on attachment 437875 [details]
Patch 1.0

View in context: https://bugs.webkit.org/attachment.cgi?id=437875&action=review

r=me

> Source/WebInspectorUI/UserInterface/Models/CSSCompletions.js:88
> +        function propertiesCallback(error, properties)

NIT: this should really be named `cssProperties` to match what's used in the protocol

[Razvan Caliman]

Created attachment 438046 [details]
Patch 1.1

Carry over R+

[EWS]

Committed r282360 (241623@main): <https://commits.webkit.org/241623@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 438046 [details].