WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
230142
Fix the lldb WTF::HashTable summary provider
https://bugs.webkit.org/show_bug.cgi?id=230142
Summary
Fix the lldb WTF::HashTable summary provider
Simon Fraser (smfr)
Reported
2021-09-09 19:08:37 PDT
Fix the lldb WTF::HashTable summary provider
Attachments
Patch
(4.85 KB, patch)
2021-09-09 19:10 PDT
,
Simon Fraser (smfr)
achristensen
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1
2021-09-09 19:10:48 PDT
Created
attachment 437824
[details]
Patch
Alex Christensen
Comment 2
2021-09-09 20:27:24 PDT
Comment on
attachment 437824
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=437824&action=review
Have you run the unit tests for this? EWS doesn't.
> Tools/lldb/lldb_webkit.py:-1076 > - table_pointer = self.valobj.GetChildMemberWithName('m_tableForLLDB')
Should we also remove m_tableForLLDB from source then?
Simon Fraser (smfr)
Comment 3
2021-09-09 20:41:09 PDT
I think we could remove m_tableForLLDB, yeah. I did test it, and the lldb tests passed (but, oddly, they passed before this change, when the provider was certainly broken for me).
Radar WebKit Bug Importer
Comment 4
2021-09-16 19:09:17 PDT
<
rdar://problem/83223014
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug