Bug 230142 - Fix the lldb WTF::HashTable summary provider
Summary: Fix the lldb WTF::HashTable summary provider
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-09-09 19:08 PDT by Simon Fraser (smfr)
Modified: 2021-09-16 19:09 PDT (History)
4 users (show)

See Also:

Attachments
Patch (4.85 KB, patch)
2021-09-09 19:10 PDT, Simon Fraser (smfr) 		achristensen: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2021-09-09 19:08:37 PDT 
Fix the lldb WTF::HashTable summary provider
Comment 1 Simon Fraser (smfr) 2021-09-09 19:10:48 PDT 
Created attachment 437824 [details]
Patch
Comment 2 Alex Christensen 2021-09-09 20:27:24 PDT 
Comment on attachment 437824 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437824&action=review

Have you run the unit tests for this?  EWS doesn't.

> Tools/lldb/lldb_webkit.py:-1076
> -        table_pointer = self.valobj.GetChildMemberWithName('m_tableForLLDB')

Should we also remove m_tableForLLDB from source then?
Comment 3 Simon Fraser (smfr) 2021-09-09 20:41:09 PDT 
I think we could remove m_tableForLLDB, yeah. I did test it, and the lldb tests passed (but, oddly, they passed before this change, when the provider was certainly broken for me).
Comment 4 Radar WebKit Bug Importer 2021-09-16 19:09:17 PDT 
<rdar://problem/83223014>