Bug 230134 - Fix some lldb data provider issues
Summary: Fix some lldb data provider issues
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-09-09 16:46 PDT by Simon Fraser (smfr)
Modified: 2021-09-09 20:03 PDT (History)
3 users (show)

See Also:

Attachments
Patch (8.44 KB, patch)
2021-09-09 16:47 PDT, Simon Fraser (smfr) 		dbates: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2021-09-09 16:46:24 PDT 
Fix some lldb data provider issues
Comment 1 Simon Fraser (smfr) 2021-09-09 16:47:52 PDT 
Created attachment 437805 [details]
Patch
Comment 2 Daniel Bates 2021-09-09 17:43:13 PDT 
Comment on attachment 437805 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437805&action=review

Patch looks good.

> Tools/lldb/lldbWebKitTester/main.cpp:33
> +#include <wtf/URL.h>

Ok as is. Thoughts on putting this in sorted order?

> Tools/lldb/lldb_webkit.py:487
> +    def _is_outOfLine(self, rgba_and_flags):

Ok as is. How about using snake casing for consistency?

> Tools/lldb/lldb_webkit.py:509
> +        out_of_line_components = self.valobj.CreateValueFromAddress('out_of_line_components', rgba_and_flags & self.COLOR_VALUE_MASK, out_of_line_components_type)

I didn't know there was such a convenience API for this. Nice.
Comment 3 Simon Fraser (smfr) 2021-09-09 20:02:33 PDT 
https://trac.webkit.org/changeset/282254/webkit
Comment 4 Radar WebKit Bug Importer 2021-09-09 20:03:17 PDT 
<rdar://problem/82956107>