Bug 230129 – Add wpts for sin,cos,tan

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Nikos Mouchtaris]

Add wpts for sin,cos,tan

[Nikos Mouchtaris]

Created attachment 437797 [details]
Patch

[EWS Watchlist]

This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess

[Simon Fraser (smfr)]

Comment on attachment 437797 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437797&action=review

r+ on the tests

> Source/WebCore/css/calc/CSSCalcOperationNode.cpp:648
> +        if (calcOperationNode.isTrigNode() && depth)

This should be done separately.

> LayoutTests/imported/w3c/web-platform-tests/css/css-values/sin-cos-tan-computed.html:5
> +<link rel="author" title="Nikos Mouchtaris" href="mailto:[e-mail]">

You don't have to give your email. I think we can just say "Apple Inc" as the author.

> LayoutTests/imported/w3c/web-platform-tests/css/css-values/sin-cos-tan-invalid.html:5
> +<link rel="author" title="Xiaocheng Hu" href="mailto:[e-mail]">

That's not you!

[Tim Nguyen (:ntim)]

Comment on attachment 437797 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437797&action=review

> LayoutTests/imported/w3c/web-platform-tests/css/support/numeric-testcommon.js:106
> +        msg = `${testString} should be ${stage}-value-equivalent to ${expectedString} ssss`;

unintentional change?

> LayoutTests/imported/w3c/web-platform-tests/css/support/numeric-testcommon.js:129
> +    }, msg || `${testString} should be ${stage}-value-equivalent sss to ${expectedString}`);

same here

> LayoutTests/imported/w3c/web-platform-tests/css/support/numeric-testcommon.js:190
> +            let parsedUsed = usedValue.split('(')[1].split(')')[0].split(',').map(parseFloat);
> +            let parsedExpected = expectedValue.split('(')[1].split(')')[0].split(',').map(parseFloat);

A regex + string.prototype.match() -> https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/match might be cleaner IMO.

I usually use this site to figure them out: https://regexr.com

[Nikos Mouchtaris]

Created attachment 438107 [details]
sin,cos,tan wpts

[Nikos Mouchtaris]

Created attachment 438151 [details]
sin,cos,tan wpts

[EWS]

Committed r282402 (241663@main): <https://commits.webkit.org/241663@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 438151 [details].

[Radar WebKit Bug Importer]

<rdar://problem/83112963>