Bug 230067 – Implement a WebProcess cap

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chris Dumez]

Implement a WebProcess cap to avoid getting into a state where we run out of resources and crash in various ways.

[Chris Dumez]

<rdar://79479244>

[Chris Dumez]

Created attachment 437668 [details]
Patch

[Geoffrey Garen]

Comment on attachment 437668 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437668&action=review

Does moving to foreground mark a process as recently used? (Would be nice to add that, if not.)

> Source/WebKit/Shared/ProcessTerminationReason.h:33
> +    ExceededProcessLimit,

Let's call this ExceededProcessCountLimit, since we call it a process count limit elsewhere.

> Source/WebKit/UIProcess/WebProcessProxy.cpp:111
> +static unsigned maxProcessCount { 400 };

s_maxProcessCount

[Chris Dumez]

Comment on attachment 437668 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437668&action=review

>> Source/WebKit/Shared/ProcessTerminationReason.h:33
>> +    ExceededProcessLimit,
> 
> Let's call this ExceededProcessCountLimit, since we call it a process count limit elsewhere.

OK.

>> Source/WebKit/UIProcess/WebProcessProxy.cpp:111
>> +static unsigned maxProcessCount { 400 };
> 
> s_maxProcessCount

I thought the s_ prefix was only used for static data members but OK.

[Chris Dumez]

(In reply to Geoffrey Garen from comment #3)
> Comment on attachment 437668 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=437668&action=review
> 
> Does moving to foreground mark a process as recently used? (Would be nice to
> add that, if not.)

It currently doesn't but this is a good point and I'll fix it.

[Chris Dumez]

Created attachment 437742 [details]
Patch

[EWS]

Committed r282218 (241505@main): <https://commits.webkit.org/241505@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 437742 [details].