Is failing on macOS wk2 and iOS.
@@ -1,4 +1,4 @@
PASS persisted() method exists and returns a Promise
-PASS persisted() returns a promise and resolves as boolean with false
+FAIL persisted() returns a promise and resolves as boolean with false assert_equals: expected false but got true
According to the history, it looks like the test started failing at https://trac.webkit.org/changeset/282130/webkit
Created attachment 437653 [details]
Comment on attachment 437653 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=437653&action=review
> + completionHandler();
This call the completion handler before the storage is actually cleared on the background thread.
> + auto callbackAggregator = CallbackAggregator::create(WTFMove(completionHandler));
Why are we using a callback aggregator for a single function call? Just pass the completion handler to clearStorage().
> + Clear storage states between tests so test does not affect each other.
test does -> tests do
Created attachment 437654 [details]
Created attachment 437655 [details]
Comment on attachment 437655 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=437655&action=review
> + Coverd by existing tests.
Created attachment 437661 [details]
Patch for landing
Committed r282170 (241462@main): <https://commits.webkit.org/241462@main>
All reviewed patches have been landed. Closing bug and clearing flags on attachment 437661 [details].
*** Bug 230068 has been marked as a duplicate of this bug. ***