imported/w3c/web-platform-tests/storage/persisted.https.any.html Is failing on macOS wk2 and iOS. History: https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fstorage%2Fpersisted.https.any.html Diff: --- /Volumes/Data/worker/bigsur-debug-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/storage/persisted.https.any-expected.txt +++ /Volumes/Data/worker/bigsur-debug-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/storage/persisted.https.any-actual.txt @@ -1,4 +1,4 @@ PASS persisted() method exists and returns a Promise -PASS persisted() returns a promise and resolves as boolean with false +FAIL persisted() returns a promise and resolves as boolean with false assert_equals: expected false but got true According to the history, it looks like the test started failing at https://trac.webkit.org/changeset/282130/webkit
<rdar://problem/82879548>
Created attachment 437653 [details] Patch
Comment on attachment 437653 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=437653&action=review > Source/WebKit/NetworkProcess/NetworkProcess.cpp:2424 > + completionHandler(); This call the completion handler before the storage is actually cleared on the background thread. > Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:2159 > + auto callbackAggregator = CallbackAggregator::create(WTFMove(completionHandler)); Why are we using a callback aggregator for a single function call? Just pass the completion handler to clearStorage(). > Tools/ChangeLog:9 > + Clear storage states between tests so test does not affect each other. test does -> tests do
Created attachment 437654 [details] Patch
Created attachment 437655 [details] Patch
Comment on attachment 437655 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=437655&action=review > Source/WebKit/ChangeLog:11 > + Coverd by existing tests. Typo: Covered
Created attachment 437661 [details] Patch for landing
Committed r282170 (241462@main): <https://commits.webkit.org/241462@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 437661 [details].
*** Bug 230068 has been marked as a duplicate of this bug. ***