Bug 230052 - Add PrivateClickMeasurement daemon
Summary: Add PrivateClickMeasurement daemon
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks: 231817
  Show dependency tree / graph
 
Reported: 2021-09-08 10:02 PDT by Alex Christensen
Modified: 2021-10-15 10:34 PDT (History)
5 users (show)

See Also:

Attachments
Patch (104.39 KB, patch)
2021-09-08 15:59 PDT, Alex Christensen 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (104.40 KB, patch)
2021-09-08 16:39 PDT, Alex Christensen 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (104.26 KB, patch)
2021-09-08 16:46 PDT, Alex Christensen 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (104.27 KB, patch)
2021-09-08 16:57 PDT, Alex Christensen 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (104.01 KB, patch)
2021-09-08 17:08 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (104.40 KB, patch)
2021-09-08 20:59 PDT, Alex Christensen 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (104.49 KB, patch)
2021-09-08 21:04 PDT, Alex Christensen 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (105.76 KB, patch)
2021-09-08 21:21 PDT, Alex Christensen 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (106.56 KB, patch)
2021-09-08 21:55 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (8) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2021-09-08 10:02:19 PDT 
Add PrivateClickMeasurement daemon
Comment 1 Alex Christensen 2021-09-08 15:59:32 PDT 
Created attachment 437672 [details]
Patch
Comment 2 Alex Christensen 2021-09-08 16:39:26 PDT 
Created attachment 437679 [details]
Patch
Comment 3 Alex Christensen 2021-09-08 16:46:42 PDT 
Created attachment 437681 [details]
Patch
Comment 4 Alex Christensen 2021-09-08 16:57:36 PDT 
Created attachment 437684 [details]
Patch
Comment 5 Alex Christensen 2021-09-08 17:08:19 PDT 
Created attachment 437686 [details]
Patch
Comment 6 Alex Christensen 2021-09-08 20:59:14 PDT 
Created attachment 437704 [details]
Patch
Comment 7 Alex Christensen 2021-09-08 21:04:29 PDT 
Created attachment 437705 [details]
Patch
Comment 8 Alex Christensen 2021-09-08 21:21:04 PDT 
Created attachment 437706 [details]
Patch
Comment 9 Alex Christensen 2021-09-08 21:55:48 PDT 
Created attachment 437709 [details]
Patch
Comment 10 Chris Dumez 2021-09-09 10:43:53 PDT 
Comment on attachment 437709 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437709&action=review

> Source/WebKit/NetworkProcess/PrivateClickMeasurement/cocoa/PrivateClickMeasurementDaemonConnectionCocoa.mm:46
> +            ASSERT(RunLoop::isMain());

Is that guaranteed?
Comment 11 Alex Christensen 2021-09-09 10:45:57 PDT 
Comment on attachment 437709 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437709&action=review

>> Source/WebKit/NetworkProcess/PrivateClickMeasurement/cocoa/PrivateClickMeasurementDaemonConnectionCocoa.mm:46
>> +            ASSERT(RunLoop::isMain());
> 
> Is that guaranteed?

It is because we use dispatch_get_main_queue when creating this connection.
Comment 12 EWS 2021-09-09 11:25:50 PDT 
Committed r282230 (241514@main): <https://commits.webkit.org/241514@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 437709 [details].
Comment 13 Radar WebKit Bug Importer 2021-09-09 11:26:24 PDT 
<rdar://problem/82935590>