Bug 23003 - [Canvas] Cairo needs arcTo
Summary: [Canvas] Cairo needs arcTo
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL: http://canvex.lazyilluminati.com/misc...
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-27 08:06 PST by Dirk Schulze
Modified: 2008-12-29 23:37 PST (History)
0 users

See Also:

Attachments
arcTo for PathCairo (4.43 KB, patch)
2008-12-27 08:21 PST, Dirk Schulze 		no flags Details | Formatted Diff | Diff
Implementation drawing (15.17 KB, image/svg+xml)
2008-12-27 08:24 PST, Dirk Schulze 		no flags Details
arcTo for PathCairo (4.49 KB, patch)
2008-12-29 06:55 PST, Dirk Schulze 		oliver: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Schulze 2008-12-27 08:06:46 PST 
Cario needs arcTo support for canvas.
Comment 1 Dirk Schulze 2008-12-27 08:21:48 PST 
Created attachment 26266 [details]
arcTo for PathCairo

This implementation is based on vector analysis. I'll add a graphic, to help understanding the patch.
Comment 2 Dirk Schulze 2008-12-27 08:24:39 PST 
Created attachment 26267 [details]
Implementation drawing

I hope this SVG helps the reviewer to understand the patch.
Comment 3 Dirk Schulze 2008-12-29 06:55:38 PST 
Created attachment 26292 [details]
arcTo for PathCairo

forgot a check if ea should be more or less than pi.
Comment 4 Oliver Hunt 2008-12-29 23:25:52 PST 
Comment on attachment 26292 [details]
arcTo for PathCairo

r=me
Comment 5 Dirk Schulze 2008-12-29 23:37:41 PST 
landed in r39511.