Bug 230022 – Remove unneeded call on startup of WebContent process

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Per Arne Vollan]

There is no need to call CGSShutdownServerConnections during startup of the WebContent process on macOS, since we already have asserted that there are no open connections at this point.

[Radar WebKit Bug Importer]

<rdar://problem/82838000>

[Per Arne Vollan]

Created attachment 437554 [details]
Patch

[Darin Adler]

Comment on attachment 437554 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437554&action=review

> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:-636
> -    // Make sure that we close any WindowServer connections after checking in with Launch Services.
> -    CGSShutdownServerConnections();

Can we also take this out of CoreGraphicsSPI.h?

[Per Arne Vollan]

(In reply to Darin Adler from comment #3)
> Comment on attachment 437554 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=437554&action=review
> 
> > Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:-636
> > -    // Make sure that we close any WindowServer connections after checking in with Launch Services.
> > -    CGSShutdownServerConnections();
> 
> Can we also take this out of CoreGraphicsSPI.h?

Yes, that's a good point, will fix.

Thanks for reviewing!

[Per Arne Vollan]

Created attachment 437564 [details]
Patch

[EWS]

Committed r282157 (241449@main): <https://commits.webkit.org/241449@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 437564 [details].