Bug 230022 - Remove unneeded call on startup of WebContent process
Summary: Remove unneeded call on startup of WebContent process
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-09-07 13:54 PDT by Per Arne Vollan
Modified: 2021-09-08 10:31 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.66 KB, patch)
2021-09-07 14:01 PDT, Per Arne Vollan
darin: review+
Details | Formatted Diff | Diff
Patch (2.94 KB, patch)
2021-09-07 15:34 PDT, Per Arne Vollan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2021-09-07 13:54:52 PDT
There is no need to call CGSShutdownServerConnections during startup of the WebContent process on macOS, since we already have asserted that there are no open connections at this point.
Comment 1 Radar WebKit Bug Importer 2021-09-07 13:55:32 PDT
<rdar://problem/82838000>
Comment 2 Per Arne Vollan 2021-09-07 14:01:46 PDT
Created attachment 437554 [details]
Patch
Comment 3 Darin Adler 2021-09-07 14:07:24 PDT
Comment on attachment 437554 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437554&action=review

> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:-636
> -    // Make sure that we close any WindowServer connections after checking in with Launch Services.
> -    CGSShutdownServerConnections();

Can we also take this out of CoreGraphicsSPI.h?
Comment 4 Per Arne Vollan 2021-09-07 14:10:29 PDT
(In reply to Darin Adler from comment #3)
> Comment on attachment 437554 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=437554&action=review
> 
> > Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:-636
> > -    // Make sure that we close any WindowServer connections after checking in with Launch Services.
> > -    CGSShutdownServerConnections();
> 
> Can we also take this out of CoreGraphicsSPI.h?

Yes, that's a good point, will fix.

Thanks for reviewing!
Comment 5 Per Arne Vollan 2021-09-07 15:34:44 PDT
Created attachment 437564 [details]
Patch
Comment 6 EWS 2021-09-08 10:31:04 PDT
Committed r282157 (241449@main): <https://commits.webkit.org/241449@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 437564 [details].