Bug 229995 - TestWebKitAPI.EventAttribution.Basic is extremely flaky on api-ios
Summary: TestWebKitAPI.EventAttribution.Basic is extremely flaky on api-ios
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
: 229852 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-09-07 04:31 PDT by Aakash Jain
Modified: 2021-09-13 09:38 PDT (History)
8 users (show)

See Also:


Attachments
Patch (2.63 KB, patch)
2021-09-07 10:49 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (2.25 KB, patch)
2021-09-07 10:51 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (2.25 KB, patch)
2021-09-07 10:54 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Aakash Jain 2021-09-07 04:33:50 PDT
Unfortunately https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.EventAttribution.Basic doesn't have lot of data for iOS release because of Bug 229994.
Comment 2 Aakash Jain 2021-09-07 04:34:31 PDT Comment hidden (obsolete)
Comment 3 Aakash Jain 2021-09-07 04:34:55 PDT
Recent changes in EventAttribution.mm were in r281723 and r281779
Comment 4 Aakash Jain 2021-09-07 04:41:01 PDT
Committed r282079 (241379@main): <https://commits.webkit.org/241379@main>
Comment 5 ayumi_kojima 2021-09-07 09:46:35 PDT
Tried on both iOS 14 simulator and BigSur, but I was not able to reproduce the timeout locally using run-api-tests --iterations 50 --ios-simulator TestWebKitAPI.EventAttribution.Basic --release.
Comment 6 Radar WebKit Bug Importer 2021-09-07 09:47:23 PDT
<rdar://problem/82826500>
Comment 7 Jonathan Bedard 2021-09-07 10:16:37 PDT
(In reply to ayumi_kojima from comment #5)
> Tried on both iOS 14 simulator and BigSur, but I was not able to reproduce
> the timeout locally using run-api-tests --iterations 50 --ios-simulator
> TestWebKitAPI.EventAttribution.Basic --release.

Try just `TestWebKitAPI.EventAttribution`, bet we have some test results poisoning one another.
Comment 8 Alex Christensen 2021-09-07 10:17:27 PDT
I'm looking into this.  I bet adding more tests caused state to be left on disk from one test affecting a future test.
Comment 9 Alex Christensen 2021-09-07 10:49:03 PDT
Created attachment 437531 [details]
Patch
Comment 10 Alex Christensen 2021-09-07 10:51:10 PDT
Created attachment 437533 [details]
Patch
Comment 11 Alex Christensen 2021-09-07 10:54:31 PDT
Created attachment 437534 [details]
Patch
Comment 12 EWS 2021-09-07 11:29:09 PDT
Committed r282102 (241400@main): <https://commits.webkit.org/241400@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 437534 [details].
Comment 13 Alex Christensen 2021-09-13 09:38:58 PDT
*** Bug 229852 has been marked as a duplicate of this bug. ***