WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
229995
TestWebKitAPI.EventAttribution.Basic is extremely flaky on api-ios
https://bugs.webkit.org/show_bug.cgi?id=229995
Summary
TestWebKitAPI.EventAttribution.Basic is extremely flaky on api-ios
Aakash Jain
Reported
2021-09-07 04:31:06 PDT
TestWebKitAPI.EventAttribution.Basic has become extremely flaky on api-ios EWS since last few days. It is frequently causing false positives on EWS, blaming innocent patches for causing this test failure. e.g.:
https://ews-build.webkit.org/#/builders/9/builds/53916
https://ews-build.webkit.org/#/builders/9/builds/53850
https://ews-build.webkit.org/#/builders/9/builds/53855
https://ews-build.webkit.org/#/builders/9/builds/53858
https://ews-build.webkit.org/#/builders/9/builds/53871
https://ews-build.webkit.org/#/builders/9/builds/53878
https://ews-build.webkit.org/#/builders/9/builds/53884
Attachments
Patch
(2.63 KB, patch)
2021-09-07 10:49 PDT
,
Alex Christensen
no flags
Details
Formatted Diff
Diff
Patch
(2.25 KB, patch)
2021-09-07 10:51 PDT
,
Alex Christensen
no flags
Details
Formatted Diff
Diff
Patch
(2.25 KB, patch)
2021-09-07 10:54 PDT
,
Alex Christensen
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Aakash Jain
Comment 1
2021-09-07 04:33:50 PDT
Unfortunately
https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.EventAttribution.Basic
doesn't have lot of data for iOS release because of
Bug 229994
.
Aakash Jain
Comment 2
2021-09-07 04:34:31 PDT
Comment hidden (obsolete)
Recent changes in were in
r281723
and
r281779
.
Aakash Jain
Comment 3
2021-09-07 04:34:55 PDT
Recent changes in EventAttribution.mm were in
r281723
and
r281779
Aakash Jain
Comment 4
2021-09-07 04:41:01 PDT
Committed
r282079
(
241379@main
): <
https://commits.webkit.org/241379@main
>
ayumi_kojima
Comment 5
2021-09-07 09:46:35 PDT
Tried on both iOS 14 simulator and BigSur, but I was not able to reproduce the timeout locally using run-api-tests --iterations 50 --ios-simulator TestWebKitAPI.EventAttribution.Basic --release.
Radar WebKit Bug Importer
Comment 6
2021-09-07 09:47:23 PDT
<
rdar://problem/82826500
>
Jonathan Bedard
Comment 7
2021-09-07 10:16:37 PDT
(In reply to ayumi_kojima from
comment #5
)
> Tried on both iOS 14 simulator and BigSur, but I was not able to reproduce > the timeout locally using run-api-tests --iterations 50 --ios-simulator > TestWebKitAPI.EventAttribution.Basic --release.
Try just `TestWebKitAPI.EventAttribution`, bet we have some test results poisoning one another.
Alex Christensen
Comment 8
2021-09-07 10:17:27 PDT
I'm looking into this. I bet adding more tests caused state to be left on disk from one test affecting a future test.
Alex Christensen
Comment 9
2021-09-07 10:49:03 PDT
Created
attachment 437531
[details]
Patch
Alex Christensen
Comment 10
2021-09-07 10:51:10 PDT
Created
attachment 437533
[details]
Patch
Alex Christensen
Comment 11
2021-09-07 10:54:31 PDT
Created
attachment 437534
[details]
Patch
EWS
Comment 12
2021-09-07 11:29:09 PDT
Committed
r282102
(
241400@main
): <
https://commits.webkit.org/241400@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 437534
[details]
.
Alex Christensen
Comment 13
2021-09-13 09:38:58 PDT
***
Bug 229852
has been marked as a duplicate of this bug. ***
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug