Bug 229976 – [WinCairo] Support prefers-color-scheme media query

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Fujii Hironori]

[WinCairo] Support prefers-color-scheme media query

See also:

  Bug 190499 – Add support for prefers-color-scheme media query
  Bug 196685 – [GTK] Support prefers-color-scheme media query

[Fujii Hironori]

https://kuro.netlify.app/ doesn't have a background image in WinCairo.
It doesn't support browsers not supporting prefers-color-scheme.

> @media (prefers-color-scheme: light) {
>     body{
>         background: url("img/bglight.svg") no-repeat;
>     }
> }
> 
> @media (prefers-color-scheme: dark) {
>     body{
>         background: url("img/bgdark.svg") no-repeat;
>     }
> }

[Fujii Hironori]

The dark mode win32 API is still undocumented.

Discussion: Dark mode for applications · Issue #41 · microsoft/WindowsAppSDK
https://github.com/microsoft/WindowsAppSDK/issues/41

windows - Win10 dark theme - how to use in WINAPI? - Stack Overflow
https://stackoverflow.com/q/53501268

[Fujii Hironori]

Created attachment 437445 [details]
Patch

[Don Olmstead]

Comment on attachment 437445 [details]
Patch

r=me

Can you open a bug for an actual implementation of dark mode on Windows?

[Fujii Hironori]

Comment on attachment 437445 [details]
Patch

Clearing flags on attachment: 437445

Committed r282123 (241420@main): <https://commits.webkit.org/241420@main>

[Fujii Hironori]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/82850531>

[Fujii Hironori]

Filed: Bug 230032 – [WinCairo] Add dark mode support

[Fujii Hironori]

(In reply to Fujii Hironori from comment #5)
> Committed r282123 (241420@main): <https://commits.webkit.org/241420@main>

This change causes new test failures for WinCairo.
Filed: Bug 230077 – [Win] REGRESSION(r282123): some layout tests are failing because the bgcolor of text input forms are unexpectedly black