Bug 229944 - Use event queue to fire RTCPeerConnection events
Summary: Use event queue to fire RTCPeerConnection events
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-09-06 02:17 PDT by youenn fablet
Modified: 2021-09-15 02:11 PDT (History)
10 users (show)

See Also:

Attachments
Patch (3.72 KB, patch)
2021-09-06 02:20 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (43.80 KB, patch)
2021-09-14 03:18 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (50.78 KB, patch)
2021-09-14 07:55 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (157.18 KB, patch)
2021-09-15 01:15 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2021-09-06 02:17:31 PDT 
Use event queue to fire RTCPeerConnection events
Comment 1 youenn fablet 2021-09-06 02:20:22 PDT 
Created attachment 437399 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2021-09-13 02:18:16 PDT 
<rdar://problem/83045723>
Comment 3 youenn fablet 2021-09-14 03:18:10 PDT 
Created attachment 438119 [details]
Patch
Comment 4 youenn fablet 2021-09-14 07:55:27 PDT 
Created attachment 438142 [details]
Patch
Comment 5 Eric Carlson 2021-09-14 08:36:46 PDT 
Comment on attachment 438142 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438142&action=review

> Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp:235
> +            m_peerConnection.dispatchEvent(RTCTrackEvent::create(eventNames().trackEvent, Event::CanBubble::No, Event::IsCancelable::No, WTFMove(event.receiver), WTFMove(event.track), WTFMove(event.streams), WTFMove(event.transceiver)));

Why are some events dispatched synchronously instead of on the task queue?
Comment 6 youenn fablet 2021-09-15 01:15:02 PDT 
Created attachment 438222 [details]
Patch for landing
Comment 7 EWS 2021-09-15 02:11:57 PDT 
Committed r282445 (241698@main): <https://commits.webkit.org/241698@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 438222 [details].